<div dir="ltr">Presumably to prevent images from being deleted for arbitrary reasons that are left to the administrator(s) of each individual implementation of OpenStack, though. Using the protected flag to prevent images that are in use from being deleted obviates the ability to use it for arbitrary protection. That is, it can either be used as a general purpose flag to prevent deletion of an image; or it can be used as a flag for images that are in use and thus must not be deleted; but it cannot be used for both. (At least, not without a wild and woolly network of hacks to ensure that it can serve both purposes.)<div><br></div><div>Given the general-purpose nature of the flag, I don't think that something that should be taken away from the administrators. And yet, it's very desirable to prevent deletion of images that are in use. I think both of these things should be supported, at the same time on the same installation. I do not consider it a solution to the problem that images can be deleted in use to take the "protected" flag away from arbitrary, bespoke use.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 18, 2014 at 6:44 PM, Jay Pipes <span dir="ltr"><<a href="mailto:jaypipes@gmail.com" target="_blank">jaypipes@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 12/18/2014 02:08 PM, Chris St. Pierre wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I wasn't suggesting that we *actually* use filesystem link count, and<br>
make hard links or whatever for every time the image is used. That's<br>
prima facie absurd, for a lot more reasons that you point out. I was<br>
suggesting a new database field that tracks the number of times an image<br>
is in use, by *analogy* with filesystem link counts. (If I wanted to be<br>
unnecessarily abrasive I might say, "This is a textbook example of<br>
something called an analogy," but I'm not interested in being<br>
unnecessarily abrasive.)<br>
<br>
Overloading the protected flag is *still* a terrible hack. Even if we<br>
tracked the initial state of "protected" and restored that state when an<br>
image went out of use, that would negate the ability to make an image<br>
</blockquote>
<br></span>
I guess I don't understand what you consider to be overloading of the protected flag. The original purpose of the protected flag was to protect images from being deleted.<br>
<br>
Best,<br>
-jay<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
protected while it was in use and expect that change to remain in place.<br>
So that just violates the principle of least surprise. Of course, we<br>
could have glance modify the "original_protected_state" flag when that<br>
flag is non-null and the user changes the actual "protected" flag, but<br>
this is just layering hacks upon hacks. By actually tracking the number<br>
of times an image is in use, we can preserve the ability to protect<br>
images *and* avoid deleting images in use.<br>
<br>
On Thu, Dec 18, 2014 at 5:27 AM, Kuvaja, Erno <<a href="mailto:kuvaja@hp.com" target="_blank">kuvaja@hp.com</a><br></span><span class="">
<mailto:<a href="mailto:kuvaja@hp.com" target="_blank">kuvaja@hp.com</a>>> wrote:<br>
<br>
I think that’s horrible idea. How do we do that store independent<br></span>
with the linking dependencies?____<br>
<br>
__ __<span class=""><br>
<br>
We should not depend universal use case like this on limited subset<br>
of backends, specially non-OpenStack ones. Glance (nor Nova) should<br>
never depend having direct access to the actual medium where the<br>
images are stored. I think this is school book example for something<br>
called database. Well arguable if this should be tracked at Glance<br>
or Nova, but definitely not a dirty hack expecting specific backend<br></span>
characteristics.____<br>
<br>
__ __<span class=""><br>
<br>
As mentioned before the protected image property is to ensure that<br>
the image does not get deleted, that is also easy to track when the<br>
images are queried. Perhaps the record needs to track the original<br>
state of protected flag, image id and use count. 3 column table and<br>
couple of API calls. Lets not at least make it any more complicated<br></span>
than it needs to be if such functionality is desired.____<br>
<br>
__ __<br>
<br>
__-__Erno____<br>
<br>
__ __<br>
<br>
*From:*Nikhil Komawar [mailto:<a href="mailto:nikhil.komawar@RACKSPACE.COM" target="_blank">nikhil.komawar@<u></u>RACKSPACE.COM</a><br>
<mailto:<a href="mailto:nikhil.komawar@RACKSPACE.COM" target="_blank">nikhil.komawar@<u></u>RACKSPACE.COM</a>>]<br>
*Sent:* 17 December 2014 20:34<br>
<br>
<br>
*To:* OpenStack Development Mailing List (not for usage questions)<br>
*Subject:* Re: [openstack-dev] [glance] Option to skip deleting<br>
images in use?____<br>
<br>
__ __<span class=""><br>
<br>
Guess that's a implementation detail. Depends on the way you go<br></span>
about using what's available now, I suppose.____<br>
<br>
__ __<br>
<br>
Thanks,<br>
-Nikhil____<br>
<br>
------------------------------<u></u>------------------------------<u></u>------------<br>
<br>
*From:*Chris St. Pierre [<a href="mailto:chris.a.st.pierre@gmail.com" target="_blank">chris.a.st.pierre@gmail.com</a><br>
<mailto:<a href="mailto:chris.a.st.pierre@gmail.com" target="_blank">chris.a.st.pierre@<u></u>gmail.com</a>>]<br>
*Sent:* Wednesday, December 17, 2014 2:07 PM<br>
*To:* OpenStack Development Mailing List (not for usage questions)<br>
*Subject:* Re: [openstack-dev] [glance] Option to skip deleting<br>
images in use?____<span class=""><br>
<br>
I was assuming atomic increment/decrement operations, in which case<br>
I'm not sure I see the race conditions. Or is atomism assuming too<br></span>
much?____<br>
<br>
__ __<span class=""><br>
<br>
On Wed, Dec 17, 2014 at 11:59 AM, Nikhil Komawar<br></span>
<<a href="mailto:nikhil.komawar@rackspace.com" target="_blank">nikhil.komawar@rackspace.com</a> <mailto:<a href="mailto:nikhil.komawar@rackspace.com" target="_blank">nikhil.komawar@<u></u>rackspace.com</a>>><br>
wrote:____<span class=""><br>
<br>
That looks like a decent alternative if it works. However, it<br>
would be too racy unless we we implement a test-and-set for such<br>
properties or there is a different job which queues up these<br></span>
requests and perform sequentially for each tenant.____<br>
<br>
__ __<br>
<br>
Thanks,<br>
-Nikhil____<br>
<br>
------------------------------<u></u>------------------------------<u></u>------------<br>
<br>
*From:*Chris St. Pierre [<a href="mailto:chris.a.st.pierre@gmail.com" target="_blank">chris.a.st.pierre@gmail.com</a><br>
<mailto:<a href="mailto:chris.a.st.pierre@gmail.com" target="_blank">chris.a.st.pierre@<u></u>gmail.com</a>>]<br>
*Sent:* Wednesday, December 17, 2014 10:23 AM<br>
*To:* OpenStack Development Mailing List (not for usage questions)<br>
*Subject:* Re: [openstack-dev] [glance] Option to skip deleting<br>
images in use?____<br>
<br>
That's unfortunately too simple. You run into one of two cases: ____<br>
<br>
__ __<span class=""><br>
<br>
1. If the job automatically removes the protected attribute when<br>
an image is no longer in use, then you lose the ability to use<br>
"protected" on images that are not in use. I.e., there's no way<br>
to say, "nothing is currently using this image, but please keep<br>
it around." (This seems particularly useful for snapshots, for<br></span>
instance.)____<br>
<br>
__ __<span class=""><br>
<br>
2. If the job does not automatically remove the protected<br>
attribute, then an image would be protected if it had ever been<br>
in use; to delete an image, you'd have to manually un-protect<br>
it, which is a workflow that quite explicitly defeats the whole<br></span>
purpose of flagging images as protected when they're in use.____<br>
<br>
__ __<span class=""><br>
<br>
It seems like flagging an image as *not* in use is actually a<br>
fairly difficult problem, since it requires consensus among all<br></span>
components that might be using images.____<br>
<br>
__ __<span class=""><br>
<br>
The only solution that readily occurs to me would be to add<br>
something like a filesystem link count to images in Glance. Then<br>
when Nova spawns an instance, it increments the usage count;<br>
when the instance is destroyed, the usage count is decremented.<br>
And similarly with other components that use images. An image<br></span>
could only be deleted when its usage count was zero.____<br>
<br>
__ __<span class=""><br>
<br>
There are ample opportunities to get out of sync there, but it's<br>
at least a sketch of something that might work, and isn't *too*<br></span>
horribly hackish. Thoughts?____<br>
<br>
__ __<span class=""><br>
<br>
On Tue, Dec 16, 2014 at 6:11 PM, Vishvananda Ishaya<br></span>
<<a href="mailto:vishvananda@gmail.com" target="_blank">vishvananda@gmail.com</a> <mailto:<a href="mailto:vishvananda@gmail.com" target="_blank">vishvananda@gmail.com</a>><u></u>> wrote:____<span class=""><br>
<br>
A simple solution that wouldn’t require modification of<br>
glance would be a cron job<br>
that lists images and snapshots and marks them protected<br>
while they are in use.<br>
<br></span>
Vish____<span class=""><br>
<br>
<br>
On Dec 16, 2014, at 3:19 PM, Collins, Sean<br>
<<a href="mailto:Sean_Collins2@cable.comcast.com" target="_blank">Sean_Collins2@cable.comcast.<u></u>com</a><br></span><span class="">
<mailto:<a href="mailto:Sean_Collins2@cable.comcast.com" target="_blank">Sean_Collins2@cable.<u></u>comcast.com</a>>> wrote:<br>
<br>
> On Tue, Dec 16, 2014 at 05:12:31PM EST, Chris St. Pierre wrote:<br>
>> No, I'm looking to prevent images that are in use from being deleted. "In<br>
>> use" and "protected" are disjoint sets.<br>
><br>
> I have seen multiple cases of images (and snapshots) being deleted while<br>
> still in use in Nova, which leads to some very, shall we say,<br>
> interesting bugs and support problems.<br>
><br>
> I do think that we should try and determine a way forward on this, they<br>
> are indeed disjoint sets. Setting an image as protected is a proactive<br>
> measure, we should try and figure out a way to keep tenants from<br>
> shooting themselves in the foot if possible.<br>
><br>
> --<br>
> Sean M. Collins<br>
> ______________________________<u></u>_________________<br>
> OpenStack-dev mailing list<br>
><a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.<u></u>openstack.org</a><br></span>
<mailto:<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.<u></u>openstack.org</a>><span class=""><br>
><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br></span>
<mailto:<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.<u></u>openstack.org</a>><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev____" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev____</a><br>
<br>
<br>
<br>
____<br>
<br>
__ __<br>
<br>
-- ____<br>
<br>
Chris St. Pierre____<span class=""><br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br></span>
<mailto:<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.<u></u>openstack.org</a>><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev____" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev____</a><br>
<br>
<br>
<br>
____<br>
<br>
__ __<br>
<br>
-- ____<br>
<br>
Chris St. Pierre____<span class=""><br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br></span>
<mailto:<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.<u></u>openstack.org</a>><span class=""><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
<br>
<br>
<br>
<br>
--<br>
Chris St. Pierre<br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
<br>
</span></blockquote><div class="HOEnZb"><div class="h5">
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Chris St. Pierre</div>
</div>