<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div>Hi,</div><div><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">The problem with existing syntax is it is not defined: there is no docs on inlining complex variables [*], and we haven’t tested it for anything more than the simplest cases: <a href="https://github.com/stackforge/mistral/blob/master/mistral/tests/unit/workbook/v2/test_dsl_specs_v2.py#L114" class="">https://github.com/stackforge/mistral/blob/master/mistral/tests/unit/workbook/v2/test_dsl_specs_v2.py#L114</a>. I will be surprised if anyone figured how to provide a complex object as an inline parameter.</div></div></blockquote><div><br class=""></div><div>Documentation is really not complete. It’s one of the major problems we’re to fix. It’s just a matter or resources and priorities, as always.</div><div><br class=""></div><div>Disagree on testing. We tested it for cases we were interested in. The test you pointed to is not the only one. General comment: If we find that our tests insufficient let’s just go ahead and improve them.</div><div class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class="">Do you think regex is the right approach for parsing arbitrary key-values where values is arbitrary json structures? Will it work with something like </div><div class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>workflow: wf2 object_list=[ {“url”: “http://{$hostname}.<a href="http://example.com/" class="">example.com</a>:8080?x=a&y={$.b}}, 33, null, {{$.key}, [{$.value1}, {$.value2}]}</div></div></div></div></blockquote><div><br class=""></div><div>With regular expressions it just works. As it turns out shlex doesn't. What else? The example you provided is a question of limitations that every convenient thing has. These limitations should be recognized and well documented.</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class="">How much tests should we write to be confident we covered all cases? I share Lakshmi’s concern it is fragile and maintaining it reliably is difficult. </div></div></div></div></blockquote><div><br class=""></div><div>Again, proper documentation and recognition of limitations.</div><br class=""><blockquote type="cite" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class="">My preference is “option 3”, “make it work as is now”. But if it’s too hard I am ok to compromise. </div></div></div></blockquote><div><br class=""></div><div><a href="https://review.openstack.org/#/c/142452/" class="">https://review.openstack.org/#/c/142452/</a>. Took fairly reasonable amount of time for Nikolay to fix it. </div><div><br class=""></div><blockquote type="cite" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class="">Option 1 introduce a new syntax; although familiar to CLI users, I think it’s a bit out of place in YAML definition. </div></div></div></blockquote><div><br class=""></div><div>Yes, agree.</div><br class=""><blockquote type="cite" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class="">Option 4 is no go :)</div></div></div></blockquote><br class=""></div><div>Out of discussion.</div><div><br class=""></div><div><br class=""></div><div><div class="">Renat Akhmerov</div><div class="">@ Mirantis Inc.</div><div class=""><br class=""></div></div><br class=""></body></html>