<div dir="ltr"><div>Consolidating them would break it for users that have customization and extension on the two templates.<br><br></div>-Lin<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 12, 2014 at 9:20 AM, David Lyle <span dir="ltr"><<a href="mailto:dklyle0@gmail.com" target="_blank">dklyle0@gmail.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Not entirely sure why they both exist either. <div><br></div><div>So by move, you meant override (nuance). That's different and I have no issue with that.</div><div><br></div><div>I'm also fine with attempting to consolidate _conf and _scripts.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>David</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 11, 2014 at 1:22 PM, Thai Q Tran <span dir="ltr"><<a href="mailto:tqtran@us.ibm.com" target="_blank">tqtran@us.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif"><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><br></div><div style="font-family:Verdana,Arial,Helvetica,sans-serif">It would not create a circular dependency, dashboard would depend on horizon - not the latter.</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif">Scripts that are library specific will live in horizon while scripts that are panel specific will live in dashboard.</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif">Let me draw a more concrete example.</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><br></div><div style="font-family:Verdana,Arial,Helvetica,sans-serif">In Horizon</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><span style="white-space:pre-wrap"> </span>We know that _script and _conf are included in the base.html</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><span style="white-space:pre-wrap"> </span>We create a _script and _conf placeholder file for project overrides (similar to _stylesheets and _header)</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif">In Dashboard</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><span style="white-space:pre-wrap"> </span>We create a _script and _conf file with today's content</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><span style="white-space:pre-wrap"> </span>It overrides the _script and _conf file in horizon</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><span style="white-space:pre-wrap"> </span>Now we can include panel specific scripts without causing circular dependency.</div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><br></div><font face="Verdana, Arial, Helvetica, sans-serif">In fact, I would like to go further and suggest that _script and _conf be combine into a single file.</font><div><font face="Verdana, Arial, Helvetica, sans-serif">Not sure why we need two places to include scripts.</font></div><div><font face="Verdana, Arial, Helvetica, sans-serif"><br></font><br><font style="font-family:Verdana,Arial,Helvetica,sans-serif" color="#990099">-----David Lyle <<a href="mailto:dklyle0@gmail.com" target="_blank">dklyle0@gmail.com</a>> wrote: -----</font><div style="font-family:Verdana,Arial,Helvetica,sans-serif;padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px">To: "OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>From: David Lyle <<a href="mailto:dklyle0@gmail.com" target="_blank">dklyle0@gmail.com</a>><br>Date: 12/11/2014 09:23AM<br>Subject: Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard<div><div><br><br><div dir="ltr">I'm probably not understanding the nuance of the question but moving the _scripts.html file to openstack_dashboard creates some circular dependencies, does it not? templates/base.html in the horizon side of the repo includes _scripts.html and insures that the javascript needed by the existing horizon framework is present.<div><br></div><div>_conf.html seems like a better candidate for moving as it's more closely tied to the application code.</div><div><br></div><div>David</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 10, 2014 at 7:20 PM, Thai Q Tran <span dir="ltr"><<a href="mailto:tqtran@us.ibm.com" target="_blank">tqtran@us.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif">Sorry for duplicate mail, forgot the subject.<br><br><font color="#990099">-----Thai Q Tran/Silicon Valley/IBM wrote: -----</font><div style="padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px">To: "OpenStack Development Mailing List \(not for usage questions\)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>From: Thai Q Tran/Silicon Valley/IBM<br>Date: 12/10/2014 03:37PM<br>Subject: Moving _conf and _scripts to dashboard<span><br><br><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif"><div>The way we are structuring our javascripts today is complicated. All of our static javascripts reside in /horizon/static and are imported through _conf.html and _scripts.html. Notice that there are already some panel specific javascripts like: horizon.images.js, horizon.instances.js, horizon.users.js. They do not belong in horizon. They belong in openstack_dashboard because they are specific to a panel.</div><div><br></div><div>Why am I raising this issue now? In Angular, we need controllers written in javascript for each panel. As we angularize more and more panels, we need to store them in a way that make sense. To me, it make sense for us to move _conf and _scripts to openstack_dashboard. Or if this is not possible, then provide a mechanism to override them in openstack_dashboard.</div><div><br></div><div>Thoughts?</div><div>Thai</div><div><br></div><div><br></div></font></span></div></div></font>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
<div><font face="Courier New,Courier,monospace" size="3">_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br></font></div></div></div></div></div></div></font>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div></div>