<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">So folks, I had to put Alembic 0.7.1 out as I realized that the “batch” mode was being turned on for autogenerate across the board in 0.7.0, and that was not the plan.<div class=""><br class=""></div><div class="">So it is now out, and the builds are failing due to <a href="https://launchpad.net/bugs/1397796" class="">https://launchpad.net/bugs/1397796</a>.</div><div class=""><br class=""></div><div class="">There’s some nits happening on the review <a href="https://review.openstack.org/#/c/137989/" class="">https://review.openstack.org/#/c/137989/</a>, so I’m hoping someone with some Neutron cred adjust the patch to their liking and get it merged. I’m just the messenger on this. </div><div class=""><br class=""></div><div class="">- mike</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 1, 2014, at 5:43 PM, Salvatore Orlando <<a href="mailto:sorlando@nicira.com" class="">sorlando@nicira.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Thanks Mike!<div class=""><br class=""></div><div class="">I've left some comments on the patch.</div><div class="">Just out of curiosity, since now alembic can autogenerate foreign keys, are we be able to remove the logic for identifying foreign keys to add/remove [1]?</div><div class=""><br class=""></div><div class="">Salvatore</div><div class=""><br class=""></div><div class="">[1] <a href="http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/migration/alembic_migrations/heal_script.py#n205" class="">http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/migration/alembic_migrations/heal_script.py#n205</a> </div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On 1 December 2014 at 20:35, Mike Bayer <span dir="ltr" class=""><<a href="mailto:mbayer@redhat.com" target="_blank" class="">mbayer@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hey neutron -<br class="">
<br class="">
Just an FYI, I’ve added <a href="https://review.openstack.org/#/c/137989/" target="_blank" class="">https://review.openstack.org/#/c/137989/</a> / <a href="https://launchpad.net/bugs/1397796" target="_blank" class="">https://launchpad.net/bugs/1397796</a> to refer to an issue in neutron’s “heal” script that is going to start failing when I put out Alembic 0.7.1, which is potentially later today / this week.<br class="">
<br class="">
The issue is pretty straightforward, Alembic 0.7.1 is adding foreign key autogenerate (and really, could add more types of autogenerate at any time), and as these new commands are revealed within the execute_alembic_command(), they are not accounted for, so it fails. I’d recommend folks try to push this one through or otherwise decide how this issue (which should be expected to occur many more times) should be handled.<br class="">
<br class="">
Just a heads up in case you start seeing builds failing!<br class="">
<br class="">
- mike<br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
OpenStack-dev mailing list<br class="">
<a href="mailto:OpenStack-dev@lists.openstack.org" class="">OpenStack-dev@lists.openstack.org</a><br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
</blockquote></div><br class=""></div>
_______________________________________________<br class="">OpenStack-dev mailing list<br class=""><a href="mailto:OpenStack-dev@lists.openstack.org" class="">OpenStack-dev@lists.openstack.org</a><br class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br class=""></div></blockquote></div><br class=""></div></body></html>