<div dir="ltr">The confirmation modal on the top of the other modal is weird and cumbersome. I think disabling clicking outside space (staic backdrop) is the right way to go. <div><br></div><div>Anton</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 2, 2014 at 8:30 PM, Thai Q Tran <span dir="ltr"><<a href="mailto:tqtran@us.ibm.com" target="_blank">tqtran@us.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
<p><font face="sans-serif">I like David's approach, but having two modals (one for the form, one for the confirmation) on top of each other is a bit weird and would require constant checks for input.</font><br>
<font face="sans-serif">We already have three ways to close the dialog today: via the cancel button, X button, and ESC key. It's more important to me that I don't lose work by accidentally clicking outside. So from this perspective, I think that having a static behavior is the way to go. Regardless of what approach we pick, its an improvement over what we have today.</font><br>
<br>
<br>
<img width="16" height="16" src="cid:1__=07BBF731DFC982AB8f9e8a93df938@us.ibm.com" border="0" alt="Inactive hide details for Timur Sufiev ---12/02/2014 04:22:00 AM---Hello, Horizoneers and UX-ers! The default behavior of modal"><font color="#424282" face="sans-serif">Timur Sufiev ---12/02/2014 04:22:00 AM---Hello, Horizoneers and UX-ers! The default behavior of modals in Horizon (defined in turn by Bootstr</font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">Timur Sufiev <<a href="mailto:tsufiev@mirantis.com" target="_blank">tsufiev@mirantis.com</a>></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">12/02/2014 04:22 AM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">[openstack-dev] [horizon] [ux] Changing how the modals are closed in Horizon</font><br>
</p><hr width="100%" size="2" align="left" noshade style="color:#8091a5"><div><div class="h5"><br>
<br>
<br>
<font size="3" face="serif">Hello, Horizoneers and UX-ers!</font><br>
<br>
<font size="3" face="serif">The default behavior of modals in Horizon (defined in turn by Bootstrap defaults) regarding their closing is to simply close the modal once user clicks somewhere outside of it (on the backdrop element below and around the modal). This is not very convenient for the modal forms containing a lot of input - when it is closed without a warning all the data the user has already provided is lost. Keeping this in mind, I've made a patch [1] changing default Bootstrap 'modal_backdrop' parameter to 'static', which means that forms are not closed once the user clicks on a backdrop, while it's still possible to close them by pressing 'Esc' or clicking on the 'X' link at the top right border of the form. Also the patch [1] allows to customize this behavior (between 'true'-current one/'false' - no backdrop element/'static') on a per-form basis.</font><br>
<br>
<font size="3" face="serif">What I didn't know at the moment I was uploading my patch is that David Lyle had been working on a similar solution [2] some time ago. It's a bit more elaborate than mine: if the user has already filled some some inputs in the form, then a confirmation dialog is shown, otherwise the form is silently dismissed as it happens now.</font><br>
<br>
<font size="3" face="serif">The whole point of writing about this in the ML is to gather opinions which approach is better:</font><br>
<font size="3" face="serif">* stick to the current behavior;</font><br>
<font size="3" face="serif">* change the default behavior to 'static';</font><br>
<font size="3" face="serif">* use the David's solution with confirmation dialog (once it'll be rebased to the current codebase).</font><br>
<br>
<font size="3" face="serif">What do you think?</font><br>
<br>
<font size="3" face="serif">[1] </font><a href="https://review.openstack.org/#/c/113206/" target="_blank"><font size="3" color="#0000FF" face="serif"><u>https://review.openstack.org/#/c/113206/</u></font></a><br>
<font size="3" face="serif">[2] </font><a href="https://review.openstack.org/#/c/23037/" target="_blank"><font size="3" color="#0000FF" face="serif"><u>https://review.openstack.org/#/c/23037/</u></font></a><br>
<br>
<font size="3" face="serif">P.S. I remember that I promised to write this email a week ago, but better late than never :).</font><br>
<br>
<font size="3" face="serif">-- </font><br>
</div></div><font size="3" face="serif">Timur Sufiev</font><tt><font>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
</font></tt><tt><font><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></font></tt><tt><font><br>
</font></tt><br>
<p></p></div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>