<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 17, 2014 at 6:40 AM, Andrey Kurilin <span dir="ltr"><<a href="mailto:akurilin@mirantis.com" target="_blank">akurilin@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>Hi everyone!<br><br>I'm working on enabling E12*
 PEP8 rules in novaclient(status of my work listed below). Imo, PEP8 
rules should be ignored only in extreme cases/for important reasons and 
we should decrease a number of ignored rules. This helps to keep code in
 more strict, readable form, which is very important when working in 
community.<br><br>While working on rule E126, we started discussion with
 Joe Gordon about demand of these rules. I have no idea about reasons of
 why they should be ignored, so I want to know:<br>- Why these rules should be ignored?<br>- What do you think about enabling these rules?<br></div></div></blockquote><div><br></div><div>I found the source of my confusion. See my inline comments in <a href="https://review.openstack.org/#/c/122888/10/tox.ini">https://review.openstack.org/#/c/122888/10/tox.ini</a></div><div><br></div><div>Hopefully this patch should clarify things: <a href="https://review.openstack.org/129677">https://review.openstack.org/129677</a></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><br>Please, leave your opinion about E12* rules.<br><br></div><div>Already enabled rules:
<br>  E121,E125 - <a href="https://review.openstack.org/#/c/122888/" target="_blank">https://review.openstack.org/#/c/122888/</a>
<br>  E122 - <a href="https://review.openstack.org/#/c/123830/" target="_blank">https://review.openstack.org/#/c/123830/</a>
<br>  E123 - <a href="https://review.openstack.org/#/c/123831/" target="_blank">https://review.openstack.org/#/c/123831/</a>
<br> <br>Abandoned rule:
<br>  E124 - <a href="https://review.openstack.org/#/c/123832/" target="_blank">https://review.openstack.org/#/c/123832/</a>
<br> <br>Pending review:
<br>  E126 - <a href="https://review.openstack.org/#/c/123850/" target="_blank">https://review.openstack.org/#/c/123850/</a>
<br>  E127 - <a href="https://review.openstack.org/#/c/123851/" target="_blank">https://review.openstack.org/#/c/123851/</a>
<br>  E128 - <a href="https://review.openstack.org/#/c/127559/" target="_blank">https://review.openstack.org/#/c/127559/</a>
<br>  E129 - <a href="https://review.openstack.org/#/c/123852/" target="_blank">https://review.openstack.org/#/c/123852/</a><span class=""><font color="#888888"><span><font color="#888888">
</font></span></font></span></div><span class=""><font color="#888888"><span><font color="#888888"><div></div></font></span><br clear="all"><br>-- <br><div dir="ltr">Best regards,<br>Andrey Kurilin.<br></div>
</font></span></div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>