<div dir="ltr">><span style="font-family:arial,sans-serif;font-size:13px">At first step we won't implement </span><span class="" style="font-family:arial,sans-serif;font-size:13px">pylint</span><span style="font-family:arial,sans-serif;font-size:13px"> as gate job, but will add </span><span style="font-family:arial,sans-serif;font-size:13px">it at master to have a possibility to check code with </span><span class="" style="font-family:arial,sans-serif;font-size:13px">pylint</span><span style="font-family:arial,sans-serif;font-size:13px"> locally, </span><span style="font-family:arial,sans-serif;font-size:13px">if it is needed.</span><div><span style="font-family:arial,sans-serif;font-size:13px">No much sense in running it locally. It has too many false positives. The best use - see new critical errors as a non-voting job.</span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">Andrew.</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 6, 2014 at 2:38 AM, Igor Degtiarov <span dir="ltr"><<a href="mailto:idegtiarov@mirantis.com" target="_blank">idegtiarov@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">My points are next:<br>
<br>
1. Pylint check will be very useful for project, and will help to<br>
avoid critical errors or mistakes in code.<br>
<br>
2. At first step we won't implement pylint as gate job, but will add<br>
it at master to have a possibility to check code with pylint locally,<br>
if it is needed.<br>
<br>
3. In future it could be added as a non-voting job.<br>
-- Igor<br>
<br>
<br>
On Sat, Oct 4, 2014 at 1:56 AM, Angus Lees <<a href="mailto:gus@inodes.org">gus@inodes.org</a>> wrote:<br>
> You can turn off lots of the "refactor recommendation" checks. I've been<br>
> running pylint across neutron and it's uncovered half a dozen legitimate<br>
> bugs so far - and that's with many tests still disabled.<br>
><br>
> I agree that the defaults are too noisy, but its about the only tool that<br>
> does linting across files - pep8 for example only looks at the current file<br>
> (and not even the parse tree).<br>
><br>
> On 4 Oct 2014 03:22, "Doug Hellmann" <<a href="mailto:doug@doughellmann.com">doug@doughellmann.com</a>> wrote:<br>
>><br>
>><br>
>> On Oct 3, 2014, at 1:09 PM, Neal, Phil <<a href="mailto:phil.neal@hp.com">phil.neal@hp.com</a>> wrote:<br>
>><br>
>> >> From: Dina Belova [mailto:<a href="mailto:dbelova@mirantis.com">dbelova@mirantis.com</a>]<br>
>> >> On Friday, October 03, 2014 2:53 AM<br>
>> >><br>
>> >> Igor,<br>
>> >><br>
>> >> Personally this idea looks really nice to me, as this will help to<br>
>> >> avoid<br>
>> >> strange code being merged and not found via reviewing process.<br>
>> >><br>
>> >> Cheers,<br>
>> >> Dina<br>
>> >><br>
>> >> On Fri, Oct 3, 2014 at 12:40 PM, Igor Degtiarov<br>
>> >> <<a href="mailto:idegtiarov@mirantis.com">idegtiarov@mirantis.com</a>> wrote:<br>
>> >> Hi folks!<br>
>> >><br>
>> >> I try too guess do we need in ceilometer checking new patches for<br>
>> >> critical errors with pylint?<br>
>> >><br>
>> >> As far as I know Nova and Sahara and others have such check. Actually<br>
>> >> it is not checking of all project but comparing of the number of<br>
>> >> errors without new patch and with it, and if diff is more then 0 then<br>
>> >> patch are not taken.<br>
>> ><br>
>> > Looking a bit deeper it seems that Nova struggled with false positives<br>
>> > and resorted to <a href="https://review.openstack.org/#/c/28754/" target="_blank">https://review.openstack.org/#/c/28754/</a> , which layers some<br>
>> > historical checking of git on top of pylint's tendency to check only the<br>
>> > latest commit. I can't say I'm too deeply versed in the code, but it's<br>
>> > enough to make me wonder if we want to go that direction and avoid the<br>
>> > issues altogether?<br>
>><br>
>> I haven’t looked at it in a while, but I’ve never been particularly<br>
>> excited by pylint. It’s extremely picky, encourages enforcing some<br>
>> questionable rules (arbitrary limits on variable name length?), and repots a<br>
>> lot of false positives. That combination tends to result in making writing<br>
>> software annoying without helping with quality in any real way.<br>
>><br>
>> Doug<br>
>><br>
>> ><br>
>> >><br>
>> >> I have taken as pattern Sahara's solution and proposed a patch for<br>
>> >> ceilometer:<br>
>> >> <a href="https://review.openstack.org/#/c/125906/" target="_blank">https://review.openstack.org/#/c/125906/</a><br>
>> >><br>
>> >> Cheers,<br>
>> >> Igor Degtiarov<br>
>> >><br>
>> >> _______________________________________________<br>
>> >> OpenStack-dev mailing list<br>
>> >> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
>> >> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
>> >><br>
>> >><br>
>> >><br>
>> >><br>
>> >> --<br>
>> >> Best regards,<br>
>> >> Dina Belova<br>
>> >> Software Engineer<br>
>> >> Mirantis Inc.<br>
>> > _______________________________________________<br>
>> > OpenStack-dev mailing list<br>
>> > <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
>> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> OpenStack-dev mailing list<br>
>> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div>