<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 25, 2014 at 12:34 PM, Devdatta Kulkarni <span dir="ltr"><<a href="mailto:devdatta.kulkarni@rackspace.com" target="_blank">devdatta.kulkarni@rackspace.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div style="direction:ltr;font-family:Tahoma;color:rgb(0,0,0);font-size:10pt">Hi,<br>
<br>
We have faced this situation in Solum several times. And in fact this was one of the topics<br>
that we discussed in our last irc meeting.<br>
<br>
We landed on separating the sample check from pep8 gate into a non-voting gate.<br>
One reason to keep the sample check is so that when say a feature in your code fails<br>
due to some upstream changes and for which you don't have coverage in your functional tests then<br>
a non-voting but failing sample check gate can be used as a starting point of the failure investigation.<br>
<br>
More details about the discussion can be found here:<br>
<a href="http://eavesdrop.openstack.org/meetings/solum_team_meeting/2014/solum_team_meeting.2014-09-23-16.00.log.txt" target="_blank">http://eavesdrop.openstack.org/meetings/solum_team_meeting/2014/solum_team_meeting.2014-09-23-16.00.log.txt</a><br>
<br>
- Devdatta<br>
<br>
<div style="font-family:'Times New Roman';color:rgb(0,0,0);font-size:16px">
<hr>
<div style="direction:ltr"><font color="#000000" face="Tahoma"><b>From:</b> David Shrewsbury [<a href="mailto:shrewsbury.dave@gmail.com" target="_blank">shrewsbury.dave@gmail.com</a>]<br>
<b>Sent:</b> Thursday, September 25, 2014 12:42 PM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> Re: [openstack-dev] [Ironic] Get rid of the sample config file<br>
</font><br>
</div><div><div class="h5">
<div></div>
<div>
<div dir="ltr">Hi!<br>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Sep 25, 2014 at 12:23 PM, Lucas Alvares Gomes <span dir="ltr">
<<a href="mailto:lucasagomes@gmail.com" target="_blank">lucasagomes@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hi,<br>
<br>
Today we have hit the problem of having an outdated sample<br>
configuration file again[1]. The problem of the sample generation is<br>
that it picks up configuration from other projects/libs<br>
(keystoneclient in that case) and this break the Ironic gate without<br>
us doing anything.<br>
<br>
So, what you guys think about removing the test that compares the<br>
configuration files and makes it no longer gate[2]?<br>
<br>
We already have a tox command to generate the sample configuration<br>
file[3], so folks that needs it can generate it locally.<br>
<br>
Does anyone disagree?<br>
<br clear="all">
</blockquote>
<div><br>
</div>
<div>+1 to this, but I think we should document how to generate the sample config<br>
in our documentation (install guide?).<br>
</div>
</div>
<br>
</div>
<div class="gmail_extra">-Dave<br>
</div>
<div class="gmail_extra">-- <br>
<div dir="ltr">
<div>David Shrewsbury (Shrews)<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div></div></div>
</div>
</div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div><div class="gmail_extra">I tried this in Cinder a while back and was actually rather surprised by the overwhelming push-back I received from the Operator community, and whether I agreed with all of it or not, the last thing I want to do is ignore the Operators that are actually standing up and maintaining what we're building.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Really at the end of the day this isn't really that big of a deal. It's relatively easy to update the config in most of the projects "tox -egenconfig" see my posting back in May [1]. For all the more often this should happen I'm not sure why we can't have enough contributors that are just pro-active enough to "fix it up" when they see it falls out of date. </div><div class="gmail_extra"><br></div><div class="gmail_extra">John</div><div class="gmail_extra"><br></div><div class="gmail_extra">[1]: <a href="http://lists.openstack.org/pipermail/openstack-dev/2014-May/036438.html">http://lists.openstack.org/pipermail/openstack-dev/2014-May/036438.html</a></div></div>