<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Arial, sans-serif;">
<div><br>
</div>
<div>Folks – we have gotten into a couple of loose habits in our mad dash to beta 1 that we need to tighten up on. I’ve asked Ryan to set geritt up to fail reviews when the commit id does not contain one of the following, so please add them to your commit.
In addition please make your commit message useful and with enough detail that the reviewer knows what he/she is reviewing.</div>
<div><br>
</div>
<div>Implements-Story: XXX</div>
<div>Fixes-Bug: YYY</div>
<div><br>
</div>
<div>Other issues</div>
<div><br>
</div>
<div><b>Do not +2 your own patch </b>. We won’t enforce this unless we need to, but don’t do it</div>
<div><br>
</div>
<div><b>Reviewed pushed on master and containing multiple changes </b></div>
<div><br>
</div>
<blockquote style="margin:0 0 0 40px; border:none; padding:0px;">
<div>You should create a branch to hold your work and name it something that makes sense. This branch should ONLY contain this work. When you checkin your code it makes it much easier for the reviewer to understand what you are doing. If you have work that
is dependent on other work, create a dependency on your branch </div>
<div><br>
</div>
<div><span class="Apple-tab-span" style="white-space:pre"></span>I.e. Git checkout –b <branch name> where branch name is bug/1234 or implement-ui-validation</div>
<div><span class="Apple-tab-span" style="white-space:pre"></span></div>
<div><br>
</div>
<div>This is the openstack workflow – which talks about how to do dependencies, rebating etc. It’s a pretty good guide. </div>
<div><br>
</div>
<div><a href="https://wiki.openstack.org/wiki/Gerrit_Workflow#Normal_Workflow">https://wiki.openstack.org/wiki/Gerrit_Workflow#Normal_Workflow</a></div>
<div><br>
</div>
<div><br>
</div>
<div>Anyone have other guides they want to share on a good workflow?</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
</blockquote>
<div>Let me know if you have comments or suggestions.</div>
<div>
<div id="MAC_OUTLOOK_SIGNATURE"></div>
</div>
</body>
</html>