<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"HP Simplified";
panose-1:2 11 6 4 2 2 4 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"HP Simplified","sans-serif";
color:windowtext;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";
mso-fareast-language:EN-IE;}
.MsoChpDefault
{mso-style-type:export-only;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-IE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> Thu Sep 18 12:18:49 UTC 2014<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>> On 2014-09-18 08:06:11 +0000 (+0000), Sullivan, Jon Paul wrote:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> In my experience if the check results are not fresh enough the<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> recheck is automatically run. I am not on the infra team, so<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> without looking up code I am just guessing, but my guess is that<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> the workflow score change triggers the check on the presumption<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> that it has been approved, not accounting for the recent(ish)<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> update that move wip to the workflow score.<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> We turned off that behavior a couple months ago when the merge-check<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> pseudo-job was implemented to automatically -1 any open changes with<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> merge conflicts each time a new change merges to their target<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> branch. This covered the majority of the problems identified by the<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> freshness check, but without using any of our worker pool.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> This is not solely about finding reviews. It is about pruning<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> stale reviews. I think the auto-abandon code was excellent at<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>><i> doing this, but alas, it is no more.
<o:p></o:p></i></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> I think it was excellent at arbitrarily abandoning open changes<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> which happened to meet a poorly-thought-out set of criteria. I'm<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> personally quite glad it broke and we didn't waste time<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> reimplementing something similar for new Gerrit versions.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">I think that this thread has already clearly stated that core reviewers saw a benefit from the auto-abandon code.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">I think that the abandoning happening from an automated process is easier to accept than if it came from a person, and so less likely to create a poor and
emotional response.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">If your personal opinion was that it wasn’t useful to your project, then perhaps what you are really saying is that the implementation of it was not configurable
enough to allow individual projects to tailor it to their needs.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">The auto-abandon code also produced other side effects that have already been detailed in this thread, such as reminding authors they need to take action
upon a change. This is done automatically without the need for core reviewers to spend extra time deliberately looking for patches that need a nudge.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">So the removal of the auto-abandon, imho, has increased core reviewer workload, increased the chance that a good change may get ignored for extended periods
of time, and has increased the possibility of code committers becoming frustrated with core reviewers adding a wip or abandon to their patches, so a decrease in productivity all around. :(<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">>
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> --
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:EN-IE">> Jeremy Stanley<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"HP Simplified","sans-serif""><o:p> </o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:10.0pt;font-family:"HP Simplified","sans-serif";color:black;mso-fareast-language:EN-IE">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:10.0pt;font-family:Wingdings;color:navy;mso-fareast-language:EN-IE">,</span><span lang="EN-US" style="font-size:10.0pt;font-family:"HP Simplified","sans-serif";color:navy;mso-fareast-language:EN-IE">:
JonPaul.Sullivan@hp.com </span><span lang="EN-US" style="font-size:10.0pt;font-family:Wingdings;color:navy;mso-fareast-language:EN-IE">J</span><span lang="EN-US" style="font-size:10.0pt;font-family:"HP Simplified","sans-serif";color:navy;mso-fareast-language:EN-IE">
</span><i><span lang="EN-US" style="font-size:10.0pt;font-family:"HP Simplified","sans-serif";color:gray;mso-fareast-language:EN-IE">Cloud Services - @hpcloud</span></i><span lang="EN-US" style="font-size:10.0pt;font-family:"HP Simplified","sans-serif";color:navy;mso-fareast-language:EN-IE"><br>
</span><span lang="EN-US" style="font-size:10.0pt;font-family:Wingdings;color:navy;mso-fareast-language:EN-IE">(</span><span lang="EN-US" style="font-size:10.0pt;font-family:"HP Simplified","sans-serif";color:navy;mso-fareast-language:EN-IE">: +353 (91) 75
4169</span><i><span lang="EN-US" style="font-size:10.0pt;font-family:"HP Simplified","sans-serif";color:gray;mso-fareast-language:EN-IE"><o:p></o:p></span></i></p>
<p class="MsoNormal" style="text-autospace:none"><i><span lang="EN-US" style="font-size:10.0pt;font-family:"HP Simplified","sans-serif";color:gray;mso-fareast-language:EN-IE"><o:p> </o:p></span></i></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"HP Simplified","sans-serif";color:#5B9BD5;mso-fareast-language:EN-IE">Postal Address: Hewlett-Packard Galway Limited, Ballybrit Business Park, Galway.<o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"HP Simplified","sans-serif";color:#5B9BD5;mso-fareast-language:EN-IE">Registered Office: Hewlett-Packard Galway Limited, 63-74 Sir John Rogerson's Quay,
Dublin 2. <o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"HP Simplified","sans-serif";color:#5B9BD5;mso-fareast-language:EN-IE">Registered Number: 361933<o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"HP Simplified","sans-serif";color:#5B9BD5;mso-fareast-language:EN-IE"> <o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"HP Simplified","sans-serif";color:#5B9BD5;mso-fareast-language:EN-IE">The contents of this message and any attachments to it are confidential and may be
legally privileged. If you have received this message in error you should delete it from your system immediately and advise the sender.<o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"HP Simplified","sans-serif";color:#5B9BD5;mso-fareast-language:EN-IE"><o:p> </o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:8.0pt;font-family:"HP Simplified","sans-serif";color:#5B9BD5;mso-fareast-language:EN-IE">To any recipient of this message within HP, unless otherwise stated, you should consider
this message and attachments as "HP CONFIDENTIAL".<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>