<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Sep 10, 2014, at 4:34 PM, Yuriy Taraday <<a href="mailto:yorik.sar@gmail.com">yorik.sar@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 9, 2014 at 9:58 PM, Doug Hellmann <span dir="ltr"><<a href="mailto:doug@doughellmann.com" target="_blank">doug@doughellmann.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
On Sep 9, 2014, at 10:51 AM, Sean Dague <<a href="mailto:sean@dague.net">sean@dague.net</a>> wrote:<br>
<br>
> On 09/09/2014 10:41 AM, Doug Hellmann wrote:<br>
>><br>
>> On Sep 8, 2014, at 8:18 PM, James E. Blair <<a href="mailto:corvus@inaugust.com">corvus@inaugust.com</a>> wrote:<br>
>><br>
>>> Sean Dague <<a href="mailto:sean@dague.net">sean@dague.net</a>> writes:<br>
>>><br>
>>>> The crux of the issue is that zookeeper python modules are C extensions.<br>
>>>> So you have to either install from packages (which we don't do in unit<br>
>>>> tests) or install from pip, which means forcing zookeeper dev packages<br>
>>>> locally. Realistically this is the same issue we end up with for mysql<br>
>>>> and pg, but given their wider usage we just forced that pain on developers.<br>
>>> ...<br>
>>>> Which feels like we need some decoupling on our requirements vs. tox<br>
>>>> targets to get there. CC to Monty and Clark as our super awesome tox<br>
>>>> hackers to help figure out if there is a path forward here that makes sense.<br>
>>><br>
>>> From a technical standpoint, all we need to do to make this work is to<br>
>>> add the zookeeper python client bindings to (test-)requirements.txt.<br>
>>> But as you point out, that makes it more difficult for developers who<br>
>>> want to run unit tests locally without having the requisite libraries<br>
>>> and header files installed.<br>
>><br>
>> I don’t think I’ve ever tried to run any of our unit tests on a box where I hadn’t also previously run devstack to install all of those sorts of dependencies. Is that unusual?<br>
><br>
> It is for Linux users, running local unit tests is the norm for me.<br>
<br>
</span>To be clear, I run the tests on the same host where I ran devstack, not in a VM. I just use devstack as a way to bootstrap all of the libraries needed for the unit test dependencies. I guess I’m just being lazy. :-)</blockquote><div><br></div><div style="">You can't run devstack everywhere you code (and want to run tests). I, for example, can't run devstack on my work laptop because I use Gentoo there. And I have MacOS X on my home laptop, so no devstack there too. The latter should be more frequent case in the community.</div></div></div></div></blockquote><div><br></div><div>Sure, I use a Mac but develop OpenStack either on a linux cloud server or a local VM, depending on my internet access. I don’t really see any point in running the tests in an environment we don’t support.</div><div><br></div><div>Doug</div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style=""><br></div><div style="">That said I never had a problem with emerging (on either of systems) necessary C libraries for tests to run. As long as they don't pull a lot of (or any) Linux-specific dependencies, it's fine.</div><div style=""><br></div><div style="">For me this issue is the case for setuptools' extras. The only problem with them is that we can't specify them in requirement.txt files currently, so we'd have to add another hack to pbr to gather extra dependencies from files like requirements-<extra_name>.txt or smth like that.</div><div style="">Then we can provide different tox venvs for diferent extras sets.</div></div><div><br></div>-- <br><br><div>Kind regards, Yuriy.</div>
</div></div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote></div><br></body></html>