<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 3, 2014 at 11:23 AM, Doug Hellmann <span dir="ltr"><<a href="mailto:doug@doughellmann.com" target="_blank">doug@doughellmann.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div class="">
<div>
On Sep 3, 2014, at 12:20 PM, Dolph Mathews <<a href="mailto:dolph.mathews@gmail.com" target="_blank">dolph.mathews@gmail.com</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br>
<div class="gmail_quote">
On Wed, Sep 3, 2014 at 8:25 AM, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>On 09/03/2014 09:03 AM, Daniel P. Berrange wrote:<br>
> On Wed, Sep 03, 2014 at 08:37:17AM -0400, Sean Dague wrote:<br>
>> I'm not sure why people keep showing up with "sort requirements" patches<br>
>> like - <a href="https://review.openstack.org/#/c/76817/6" target="_blank">https://review.openstack.org/#/c/76817/6</a>, however, they do.<br>
>><br>
>> All of these need to be -2ed with predjudice.<br>
>><br>
>> requirements.txt is not a declarative interface. The order is important<br>
>> as pip processes it in the order it is. Changing the order has impacts<br>
>> on the overall integration which can cause wedges later.<br>
><br>
> Can requirements.txt contain comment lines ? If so, it would be<br>
> worth adding<br>
><br>
> # The ordering of modules in this file is important<br>
> # Do not attempt to re-sort the lines<br>
><br>
> Because 6 months hence people will have probably forgotten about<br>
> this mail, or if they're new contributors, never know it existed.<br>
<br>
</div>The point is that core review team members should know. In this case at<br>
least one glance core +2ed this change.<br>
<br>
Regular contributors can be educated by core team members.<br></blockquote><div><br></div><div>Regardless, tribal knowledge should be documented, and doing so in requirements files is probably the best place for that.</div>
</div></div></div></blockquote><div><br></div></div><div>+1</div><div><br></div><div>Write-it-down-ly,</div><div>Doug</div></div></div></blockquote><div><br></div><div>The blocked review Sean mentioned above happens to reference a bug that I've now marked invalid against all projects that hadn't already applied "fixes" for it:</div>
<div><br></div><div> <a href="https://bugs.launchpad.net/glance/+bug/1285478">https://bugs.launchpad.net/glance/+bug/1285478</a></div><div><br></div><div>Instead, I've opened a second task to add a note to all the requirements files:</div>
<div><br></div><div> <a href="https://bugs.launchpad.net/keystone/+bug/1365061">https://bugs.launchpad.net/keystone/+bug/1365061</a></div><div><br></div><div>All associated patches:</div><div><br></div><div> <a href="https://review.openstack.org/#/q/I64ae9191863564e278a35d42ec9cd743a233028e,n,z">https://review.openstack.org/#/q/I64ae9191863564e278a35d42ec9cd743a233028e,n,z</a><br>
</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">
<div><div class=""><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><br>
-Sean<br>
<br>
--<br>
Sean Dague<br>
<a href="http://dague.net/" target="_blank">http://dague.net</a><br>
<br>
</div><div><div>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div></div><br></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>