<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 22, 2014 at 2:11 AM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">On Thu, Aug 21, 2014 at 09:02:17AM -0700, Armando M. wrote:<br>
> Hi folks,<br>
><br>
> According to [1], we have ways to introduce external references to commit<br>
> messages.<br>
><br>
> These are useful to mark certain patches and their relevance in the context<br>
> of documentation, upgrades, etc.<br>
><br>
> I was wondering if it would be useful considering the addition of another<br>
> tag:<br>
><br>
> GateFailureFix<br>
><br>
> The objective of this tag, mainly for consumption by the review team, would<br>
> be to make sure that some patches get more attention than others, as they<br>
> affect the velocity of how certain critical issues are addressed (and gate<br>
> failures affect everyone).<br>
><br>
> As for machine consumption, I know that some projects use the<br>
> 'gate-failure' tag to categorize LP bugs that affect the gate. The use of a<br>
> GateFailureFix tag in the commit message could make the tagging automatic,<br>
> so that we can keep a log of what all the gate failures are over time.<br>
><br>
> Not sure if this was proposed before, and I welcome any input on the matter.<br>
<br>
</div></div>We've tried a number of different tags in git commit messages before, in<br>
an attempt to help prioritization of reviews and unfortunately none of them<br>
have been particularly successful so far. I think a key reasonsfor this<br>
is that tags in the commit message are invisible when people are looking at<br>
lists of possible changes to choose for review. Whether in the gerrit web<br>
UI reports / dashboards or in command line tools like my own gerrymander,<br>
reviewers are looking at lists of changes and primarily choosing which<br>
to review based on the subject line, or other explicitly recorded metadata<br>
fields. You won't typically look at the commit message until you've already<br>
decided you want to review the change. So while GateFailureFix may cause<br>
me to pay more attention during the review of it, it probably won't make<br>
me start review any sooner.<br></blockquote><div><br></div><div><br></div><div>gerrit supports searching by message (although the searching is a little odd sometimes) and these can be used in dashboards.</div><div><br></div>
<div><dt class="" style="margin-top:1em;color:rgb(0,0,0);font-family:'Times New Roman';font-size:medium">message:'MESSAGE'</dt><dd style="color:rgb(0,0,0);font-family:'Times New Roman';font-size:medium">
<div class=""><p style="margin:0.5em 0px">Changes that match <em>MESSAGE</em> arbitrary string in the commit message body.</p><p style="margin:0.5em 0px"><br></p><p style="margin:0.5em 0px"><br></p></div></dd></div><div>
<a href="https://review.openstack.org/Documentation/user-search.html">https://review.openstack.org/Documentation/user-search.html</a></div>
<div><br></div><div>Examples:</div><div><br></div><div><a href="https://review.openstack.org/#/q/message:%22UpgradeImpact%22+is:open,n,z">https://review.openstack.org/#/q/message:%22UpgradeImpact%22+is:open,n,z</a></div>
<div>
<a href="https://review.openstack.org/#/q/message:%22DocImpact%22+is:open,n,z">https://review.openstack.org/#/q/message:%22DocImpact%22+is:open,n,z</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Regards,<br>
Daniel<br>
<span class=""><font color="#888888">--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
</font></span><div class=""><div class="h5"><br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>