<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Nader,<br>
<div class="moz-cite-prefix">Le 08/08/2014 09:23, Nader Lahouti a
écrit :<br>
</div>
<blockquote
cite="mid:CAF5T5jtUcuCv0XpSssGTecxPhUjwuA3Jv2x=Lv53Bd=ZHV7=GA@mail.gmail.com"
type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div style="">Is it possible to send a patch for review (i.e. A)
on gerrit based on multiple commit under the review (i.e. B
and C)?</div>
<div style="">Based on the wiki page to add dependency these
command should be used:</div>
<div style="">A->B, A->C (no dependency between B and C)</div>
<div style="">
<pre>#fetch change under review and check out branch based on that change.
git review -d $PARENT_CHANGE_NUMBER
git checkout -b $DEV_TOPIC_BRANCH
# Edit files, add files to git
git commit
git review</pre>
</div>
<div style="">This seems to work only for one dependency. Is it
possible to repeat the first command,</div>
<div style="">(i.e. git review -d $PARENT_CHANGE_NUMBER)
multiple times for each dependency?</div>
<div style=""><br>
</div>
<div style=""><br>
</div>
</div>
</blockquote>
<br>
The thing is really simple, just create a local branch for your
patches series, and do one commit per Gerrit change.<br>
<br>
When you'll run git-review and say "yes" to what it will ask you,
there will be a commit hook which will append a Change-Id to every
commit you have in your branch, and it will publish the whole series
(so A will depend on B which itself depends on C).<br>
<br>
If you need to produce a new patchset (ie. a new iteration of a
change), you'll just have to interactively rebase your local branch
to the local master you have, edit the commit you want to amend (and
leave git pick the others) and as Git will stop on your patch to
edit when rebasing, you'll just have to --amend it and perform a git
rebase --continue.<br>
<br>
Hope it makes things clearer now,<br>
-Sylvain<br>
<blockquote
cite="mid:CAF5T5jtUcuCv0XpSssGTecxPhUjwuA3Jv2x=Lv53Bd=ZHV7=GA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div style="">Thanks,</div>
<div style="">Nader.</div>
<div style=""><br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
OpenStack-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>
<a class="moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>