<div dir="ltr">On 28 July 2014 11:37, Salvatore Orlando <span dir="ltr"><<a href="mailto:sorlando@nicira.com" target="_blank">sorlando@nicira.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote">
<div>Therefore the likeness of your patch merging depends on the specific nature of the -1 you received.</div></div></div></div></div></blockquote><div><br></div><div>This is really a key point.</div><div><br></div><div>Here is a pattern that's worth recognising:</div>
<div><br></div><div>If your code is in reasonable shape but there is no urgent need to complete the merge then the reviewer might "praise with faint damnation". That is, keep giving you -1 reviews for minor reasons until closer to the end of the merge window.</div>
<div><br></div><div>If you are an overzealous newbie you might think you need to respond to every such comment with an immediate revision, and that you might then be rewarded with a +1, but then you would just be waving a dead chicken [0] and better advised to slow down a little. (Says me who went through 19 patch sets on his first small contribution :-)).</div>
<div><br></div><div>I would hope that new contributors won't feel too much pressure to look busy. This can be a tough call when your job is to take all reasonable steps to have code accepted. It's one thing to be overzealous about answering nitpick reviews but it would be really unfortunate if you felt that you always needed to (extreme example) have an agenda item in all relevant weekly meetings e.g. NFV + Nova + Neutron + ML2 + Third party.</div>
<div><br></div><div>In any case the whole process probably goes much more smoothly once you have a chance to attend a Summit and make some friends. That might not be bad as a first step for new contributors if they have that possibility. (But then the Summit is very expensive until after your first commit is merged and you are recognised as a contributor.)</div>
<div><br></div><div>[0]: <a href="http://zvon.org/comp/r/ref-Jargon_file.html#Terms~wave_a_dead_chicken">http://zvon.org/comp/r/ref-Jargon_file.html#Terms~wave_a_dead_chicken</a><br></div><div><br></div><div><br></div></div>
</div></div>