<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; ">
<div>Hello,</div>
<div><br>
</div>
<div>Fix for the issue mentioned below has been committed and merged into the master repository. <a href="https://review.openstack.org/#/c/109149/">https://review.openstack.org/#/c/109149/</a></div>
<div>Your patch should be good to go after a rebase.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Abhishek Raut</div>
<div><br>
</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Yangxurong <<a href="mailto:yangxurong@huawei.com">yangxurong@huawei.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Wed, 23 Jul 2014 12:02:05 +0000<br>
<span style="font-weight:bold">To: </span>"<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>[openstack-dev] [OpenStack-dev][neutron] A question about cisco network_profiles.xxxx uri<br>
</div>
<div><br>
</div>
<div xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div lang="ZH-CN" link="blue" vlink="purple" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">Hi folks,<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">I</span><span lang="EN-US" style="font-size:9.0pt;color:black">’</span><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">m
planning to fix bug/1330095[1], which aims to solve the invalid suffix uri as follow, but I hit a problem of cisco n1kv plugin testing case[2].<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">[1]</span><span lang="EN-US"></span><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><a href="https://bugs.launchpad.net/neutron/+bug/1330095">https://bugs.launchpad.net/neutron/+bug/1330095</a><o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">When submitting a REST request as follow:<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">POST
<a href="http://localhost:9696/v2.0/routers.@@@xxx">http://localhost:9696/v2.0/routers.@@@xxx</a><o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">body:<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">{<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"> "router":{<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"> "name": "ddd"<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"> }<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">}<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">the request finishes without error.<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">Generally the string following "." in the request path will be matched as the format which specifies the
format of the request body, like xml or json. I think we need to check the validity of the suffix and filter out invalid format like "@@@xxx".<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">I hit one testing case failure in cisco n1kv plugin when I submit my patch:</span><span lang="EN-US"></span><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><a href="https://review.openstack.org/108683">https://review.openstack.org/108683</a><o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">[2] the issues in network_profiles.xxx uri test case:
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">/network_profiles.{'network_profile': {'segment_range': '10000-10010', 'segment_type': 'overlay', 'name':
'netp1', 'tenant_id': 'some_tenant', 'sub_type': 'enhanced', 'multicast_ip_range': '224.1.1.1-224.1.1.10'}}<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left;text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">So the content in the dictionary was matched as the format. This test case expects to catch a HTTP 400 exception.
I am not sure whether this test case is testing an invalid request path, or cisco n1kv plugin supports such path, it's some mistakes in the dictionary that cause the exception.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">Any good idea or suggestion about this issue?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:9.0pt;font-family:SimSun;color:black">XuRong Yang</span><span lang="EN-US"><o:p></o:p></span></p>
</div>
</div>
</div>
_______________________________________________ OpenStack-dev mailing list <a href="mailto:OpenStack-dev@lists.openstack.org">
OpenStack-dev@lists.openstack.org</a> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a> </span>
</body>
</html>