<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body style='font-size: 10pt; font-family: Verdana,Geneva,sans-serif'>
<p>I left a comment on one of the commits, but in general here are my thoughts:</p>
<p>1) I would prefer not to do things like switch to oslo.i18n outside of Gerrit. I realize we don't have a specific existing policy for this, but doing that significant work outside of Gerrit is not desirable IMHO. It needs to happen either before graduation or after import into Gerrit.</p>
<p>2) I definitely don't want to be accepting "enable [hacking check]" changes outside Gerrit. The github graduation step is _just_ to get the code in shape so it can be imported with the tests passing. It's perfectly acceptable to me to just ignore any hacking checks during this step and fix them in Gerrit where, again, the changes can be reviewed.</p>
<p>At a glance I don't see any problems with the changes that have been made, but I haven't looked that closely and I think it brings up some topics for clarification in the graduation process.</p>
<p>Thanks.</p>
<p>-Ben</p>
<p> </p>
<p>On 2014-07-22 08:44, gordon chung wrote:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<div dir="ltr">hi,
<div> </div>
<div>following the oslo graduation protocol, could the oslo team review the oslo.middleware library[1] i've created and see if there are any issues.</div>
<div> </div>
<div>[1] <a style="font-size: 12pt;" href="https://github.com/chungg/oslo.middleware">https://github.com/chungg/oslo.middleware</a></div>
<div> </div>
<div>cheers,<span style="font-family: Calibri;"><br /><em>gord</em></span></div>
<div><span style="font-family: Calibri;"><em> </em></span></div>
<div><span style="font-family: Calibri;"><em> </em></span></div>
</div>
<!-- html ignored --><br />
<pre>_______________________________________________
OpenStack-dev mailing list
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</blockquote>
<p> </p>
<div> </div>
</body></html>