<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>> I left a comment on one of the commits, but in general here are my thoughts:<BR>> 1) I would prefer not to do things like switch to oslo.i18n outside of Gerrit. I realize we don't have a specific existing policy for this, but doing that significant <BR><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>work outside of Gerrit is not desirable IMHO. It needs to happen either before graduation or after import into Gerrit.<BR><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>2) I definitely don't want to be accepting "enable [hacking check]" changes outside Gerrit. The github graduation step is _just_ to get the code in shape so it <BR><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>can be imported with the tests passing. It's perfectly acceptable to me to just ignore any hacking checks during this step and fix them in Gerrit where, again, <BR><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>the changes can be reviewed.<BR><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>At a glance I don't see any problems with the changes that have been made, but I haven't looked that closely and I think it brings up some topics for <BR><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>clarification in the graduation process.<BR><br><BR>i'm ok to revert if there are concerns. i just vaguely remember a reference in another oslo lib about waiting for i18n graduation but tbh i didn't actually check back to see what conclusion was.<BR><div><br></div><font face="Calibri">cheers,<br><i>gord</i></font> </div></body>
</html>