<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
p.msochpdefault, li.msochpdefault, div.msochpdefault
{mso-style-name:msochpdefault;
mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri","sans-serif";}
span.emailstyle17
{mso-style-name:emailstyle17;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:black">I have gone thru the Heat Database and found the drawbacks in the existing model as listed below.</span> Could you review and add anything missing here. Thanks.<span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">Heat Database model is having following drawbacks:<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt;text-indent:-.25in;vertical-align:middle">
<span style="color:black">1.</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif";color:black">
</span><span style="color:black">Duplicate information <o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt;text-indent:-.25in;vertical-align:middle">
<span style="color:black">2.</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif";color:black">
</span><span style="color:black">Incomplete naming of columns<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt;text-indent:-.25in;vertical-align:middle">
<span style="color:black">3.</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif";color:black">
</span><span style="color:black">Inconsistency in the identifiers (id) and deleted_at columns across the tables<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt;text-indent:-.25in;vertical-align:middle">
<span style="color:black">4.</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif";color:black">
</span><span style="color:black">resource table is specific to nova and make it generic<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt;text-indent:-.25in;vertical-align:middle">
<span style="color:black">5.</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif";color:black">
</span><span style="color:black">Pre-defined constants are not using enum.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">And the section provided below describes these problem on table vice.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="color:black">Stack</span></b><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Duplicate info<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.75in"><span style="color:black">Tenant & stack_user_project_id<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.75in"><span style="color:black">Credentials_id & username , owner_id.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:81.0pt"><span style="color:black">Tenant is also part of user_creds and Stack always has credentials_id, so what is the need of having tenant info in stack table and in stack table only the credentials_id is sufficient.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:81.0pt"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Status & action should be enum of predefined status<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="color:black">User_creads</span></b><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">correct the spelling in Truststore_id
<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="color:black">Resource</span></b><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Status & action should be enum of predefined status<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Rsrc_metadata - make full name resource_metadata<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Why only nova_instance column how about for other services like cinder, glance resource, could be renamed to be generic enough??<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="color:black">Watch_rule</span></b><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Last_evaluated -> append _at<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">State should be an enum<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="color:black">Event</span></b><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Why uuid and id both used?<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Resource_action is being used in both event and resource table, so it should be moved to common table<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:27.0pt"><span style="color:black">Resource_status should be any enum<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:black">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">Kanagaraj M <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
</div>
</body>
</html>