<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 20px; font-family: Calibri, sans-serif; ">
<div>Hello,</div>
<div>A follow-up development question related to this:</div>
<div><br>
</div>
<div>As a part of <a href="https://review.openstack.org/#/c/105563/">https://review.openstack.org/#/c/105563/</a>, which was introducing a new table in Neutron DB, I was trying to send for review a new file in <a class="gwt-InlineHyperlink" href="https://review.openstack.org/#/c/105563/4/neutron/db/migration/alembic_migrations/versions/1be5bdeb1d9a_ml2_network_overlay_type_driver.py" style="text-decoration: none; color: rgb(34, 34, 34) !important; font-family: sans-serif; font-size: small; white-space: nowrap; background-image: none !important; background-color: rgb(245, 245, 255); ">neutron/db/migration/alembic_migrations/versions/</a> which
got generated through script "neutron-db-manage". This also updated <a class="gwt-InlineHyperlink" href="https://review.openstack.org/#/c/105563/4/neutron/db/migration/alembic_migrations/versions/1be5bdeb1d9a_ml2_network_overlay_type_driver.py" style="text-decoration: none; color: rgb(34, 34, 34) !important; font-family: sans-serif; font-size: small; white-space: nowrap; background-image: none !important; background-color: rgb(245, 245, 255); ">neutron/db/migration/alembic_migrations/versions/</a>HEAD.
I was trying to send this file for review as well.</div>
<div><br>
</div>
<div>"git review" failed and I saw merge errors in <a class="gwt-InlineHyperlink" href="https://review.openstack.org/#/c/105563/4/neutron/db/migration/alembic_migrations/versions/1be5bdeb1d9a_ml2_network_overlay_type_driver.py" style="text-decoration: none; color: rgb(34, 34, 34) !important; font-family: sans-serif; font-size: small; white-space: nowrap; background-image: none !important; background-color: rgb(245, 245, 255); ">neutron/db/migration/alembic_migrations/versions/</a>HEAD. </div>
<div><br>
</div>
<div>W/O HEAD modified, jenkins was failing. I am working to fix this and saw this e-mail. </div>
<div><br>
</div>
<div>I had to go through all the links in detail in this thread. But, meanwhile, the two points mentioned below looks related to the patch/issues I am facing. </div>
<div>So, if I add a new table, I don't need to run the "neutron-db-manage" script to generate the file and modify the HEAD anymore? Is (2) below need to be done manually?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Paddu</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Anna Kamyshnikova <<a href="mailto:akamyshnikova@mirantis.com">akamyshnikova@mirantis.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Wednesday, July 16, 2014 1:14 AM<br>
<span style="font-weight:bold">To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] [Neutron] Gap 0 (database migrations) closed!<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">
<div>Hello everyone!</div>
<div><br>
</div>
<div>I would like to bring the next two points to everybody's attention:</div>
<div><br>
</div>
<div>1) As Henry mentioned if you add new migration you should make it unconditional. Conditional migrations should not be merged since now.</div>
<div><br>
</div>
<div>2) If you add some new models you should ensure that module containing it is imported in /neutron/db/migration/models/head.py.</div>
<div><br>
</div>
<div>The second point in important for testing which I hope will be merged soon: <a href="https://review.openstack.org/76520">
https://review.openstack.org/76520</a>.</div>
<div><br>
</div>
<div>Regards,<br>
Ann</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Jul 16, 2014 at 5:54 AM, Kyle Mestery <span dir="ltr">
<<a href="mailto:mestery@mestery.com" target="_blank">mestery@mestery.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">On Tue, Jul 15, 2014 at 5:49 PM, Henry Gessau <<a href="mailto:gessau@cisco.com">gessau@cisco.com</a>> wrote:<br>
> I am happy to announce that the first (zero'th?) item in the Neutron Gap<br>
> Coverage[1] has merged[2]. The Neutron database now contains all tables for<br>
> all plugins, and database migrations are no longer conditional on the<br>
> configuration.<br>
><br>
> In the short term, Neutron developers who write migration scripts need to set<br>
> migration_for_plugins = ['*']<br>
> but we will soon clean up the template for migration scripts so that this will<br>
> be unnecessary.<br>
><br>
> I would like to say special thanks to Ann Kamyshnikova and Jakub Libosvar for<br>
> their great work on this solution. Also thanks to Salvatore Orlando and Mark<br>
> McClain for mentoring this through to the finish.<br>
><br>
> [1]<br>
> <a href="https://wiki.openstack.org/wiki/Governance/TechnicalCommittee/Neutron_Gap_Coverage" target="_blank">
https://wiki.openstack.org/wiki/Governance/TechnicalCommittee/Neutron_Gap_Coverage</a><br>
> [2] <a href="https://review.openstack.org/96438" target="_blank">https://review.openstack.org/96438</a><br>
><br>
</div>
This is great news! Thanks to everyone who worked on this particular<br>
gap. We're making progress on the other gaps identified in that plan,<br>
I'll send an email out once Juno-2 closes with where we're at.<br>
<br>
Thanks,<br>
Kyle<br>
<div class="HOEnZb">
<div class="h5"><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</span>
</body>
</html>