<div dir="ltr"><div class="gmail_default" style="font-family:courier new,monospace"><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 14, 2014 at 8:38 AM, Duncan Thomas <span dir="ltr"><<a href="mailto:duncan.thomas@gmail.com" target="_blank">duncan.thomas@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On 14 July 2014 07:11, Flavio Percoco <<a href="mailto:flavio@redhat.com">flavio@redhat.com</a>> wrote:<br>
> I almost fully agree with this last point. The bit I don't agree with is<br>
> that there are some small refactor changes that aim to change a core<br>
> piece of the project without any impact on the final user that are<br>
> spec/blueprint worthy to explaining the motivation, expected results and<br>
> drawbacks.<br>
><br>
> To put it in another way. Developers are consumers of project's code,<br>
> therefore the changes affecting the way developers interact with the<br>
> code are also blueprint worth it, IMHO.<br>
<br>
</div>The way I've been playing it on cinder is to ask for a spec if I'm<br>
reviewing a patch that doesn't have one and I find myself questioning<br>
the approach rather than the code.<br>
<br>
I think it is fair to say that core reviewers shouldn't be afraid to<br>
ask for a spec at any time they think it will help, guidelines aside.<br>
This allows contributors to attempt the lightweight process and skip<br>
the spec if they don't expect to need one.<br></blockquote><div><br></div><div class="gmail_default" style="font-family:'courier new',monospace">+1 This is exactly what I was hoping to see in Cinder at least.</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
Duncan Thomas<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>