<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jun 26, 2014, at 6:58 PM, wu jiang <<a href="mailto:wingwj@gmail.com">wingwj@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi Vish, thanks for your reply.<div><br></div><div>About Q1, I mean that Nova doesn't have extra processions/works for 'daily'/'weekly' than other backup_types like '123'/'test'.</div>
<div>The 'daily' & 'weekly' don't have unique places in the API than any other else.</div><div><br></div><div>But we gave them as examples in code comments especially in novaclient.<br></div><div><br>
</div><div>A few users asked me why their instances were not backup-ed automatically, they thought we have a timing task to do this if the 'backup_type' equals to 'daily'/'weekly' because we prompt them to use it.. </div>
<div>Therefore, it's useless and inclined to make confusion for this API IMO. No need to show them in code comments & novaclient.</div><div><br></div><div>P.S. So maybe 'backup_name'/'backup_tag' is a better name, but we can't modify the API for compatibility..</div></div></blockquote><div><br></div>Yes the name is confusing.</div><div><br></div><div>Vish</div><div><br><blockquote type="cite"><div dir="ltr">
<div><br></div><div><br></div><div>Thanks.</div><div><br></div><div>WingWJ</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 27, 2014 at 5:20 AM, Vishvananda Ishaya <span dir="ltr"><<a href="mailto:vishvananda@gmail.com" target="_blank">vishvananda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On Jun 26, 2014, at 5:07 AM, wu jiang <<a href="mailto:wingwj@gmail.com">wingwj@gmail.com</a>> wrote:<br>
<br>
> Hi all,<br>
><br>
> I tested the 'backup' API recently and got two questions about it:<br>
><br>
> 1. Why 'daily' & 'weekly' appear in code comments & novaclient about 'backup_type' parameter?<br>
><br>
> The 'backup_type' parameter is only a tag for this backup(image).<br>
> And there isn't corresponding validation for 'backup_type' about these two types.<br>
><br>
> Moreover, there is also no periodic_task for 'backup' in compute host.<br>
> (It's fair to leave the choice to other third-parts system)<br>
><br>
> So, why we leave 'daily | weekly' example in code comments and novaclient?<br>
> IMO it may lead confusion that Nova will do more actions for 'daily|weekly' backup request.<br>
<br>
</div>The tag affects the cleanup of old copies, so if you do a tag of ‘weekly’ and<br>
the rotation is 3, it will insure you only have 3 copies that are tagged weekly.<br>
You could also have 3 copies of the daily tag as well.<br>
<div class=""><br>
><br>
> 2. Is it necessary to backup instance when 'rotation' is equal to 0?<br>
><br>
> Let's look at related codes in nova/compute/manager.py:<br>
> # def backup_instance(self, context, image_id, instance, backup_type, rotation):<br>
> #<br>
> # self._do_snapshot_instance(context, image_id, instance, rotation)<br>
> # self._rotate_backups(context, instance, backup_type, rotation)<br>
><br>
> I knew Nova will delete all backup images according the 'backup_type' parameter when 'rotation' equals to 0.<br>
><br>
> But according the logic above, Nova will generate one new backup in _do_snapshot_instance(), and delete it in _rotate_backups()..<br>
><br>
> It's weird to snapshot a useless backup firstly IMO.<br>
> We need to add one new branch here: if 'rotation' is equal to 0, no need to backup, just rotate it.<br>
<br>
</div>That makes sense I suppose.<br>
<br>
Vish<br>
<div class=""><br>
><br>
><br>
> So, what's your opinions? Look forward to your suggestion.<br>
> Thanks.<br>
><br>
> WingWJ<br>
><br>
</div>> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote></div><br></body></html>