<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 20, 2014 at 11:07 AM, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">After seeing a bunch of code changes to enforce new hacking rules, I'd<br>
like to propose dropping some of the rules we have. The overall patch<br>
series is here -<br>
<a href="https://review.openstack.org/#/q/status:open+project:openstack-dev/hacking+branch:master+topic:be_less_silly,n,z" target="_blank">https://review.openstack.org/#/q/status:open+project:openstack-dev/hacking+branch:master+topic:be_less_silly,n,z</a><br>
<br>
H402 - 1 line doc strings should end in punctuation. The real statement<br>
is this should be a summary sentence. A sentence is not just a set of<br>
words that end in a period. Squirel fast bob. It's something deeper.<br>
This rule thus isn't really semantically useful, especially when you are<br>
talking about at 69 character maximum (79 - 4 space indent - 6 quote<br>
characters).<br></blockquote><div><br></div><div>Thoughts on removing all pep257 (<a href="http://legacy.python.org/dev/peps/pep-0257/">http://legacy.python.org/dev/peps/pep-0257/</a>) things from hacking? If projects would still like to enforce it there is a flake8 extension for pep257 itself.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
H803 - First line of a commit message must *not* end in a period. This<br>
was mostly a response to an unreasonable core reviewer that was -1ing<br>
people for not having periods. I think any core reviewer that -1s for<br>
this either way should be thrown off the island, or at least made fun<br>
of, a lot. Again, the clarity of a commit message is not made or lost by<br>
the lack or existence of a period at the end of the first line.<br></blockquote><div><br></div><div>++ for removing this, in general the git based rules are funny to enforce. As you can run 'tox -epep8' before a commit and everything will pass, then you write your commit message and now it will fail.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
H305 - Enforcement of libraries fitting correctly into stdlib, 3rdparty,<br>
our tree. This biggest issue here is it's built in a world where there<br>
was only 1 viable python version, 2.7. Python's stdlib is actually<br>
pretty dynamic and grows over time. As we embrace more python 3, and as<br>
distros start to make python3 be front and center, what does this even<br>
mean? The current enforcement can't pass on both python2 and python3 at<br>
the same time in many cases because of that.<br></blockquote><div><br></div><div>++ Oh Python 2 vs. 3</div><div><br></div><div>For this one I think we should leave the rule in HACKING.rst but explicitly document it as a recommendation, and that python2 vs python3 makes this unenforceable.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
We have to remember we're all humans, and it's ok to have grey space.<br>
Like in 305, you *should* group the libraries if you can, but stuff like<br>
that should be labeled as 'nit' in the review, and only ask the author<br>
to respin it if there are other more serious issues to be handled.<br>
<br>
Let's optimize a little more for fun, and stop throwing -1s for silly<br>
things. :)<br>
<span class=""><font color="#888888"><br>
-Sean<br>
<br>
--<br>
Sean Dague<br>
<a href="http://dague.net" target="_blank">http://dague.net</a><br>
<br>
</font></span><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>