<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I don’t think we have them. You can write them I think as a part of what you’re doing.<div><br><div>
<div>Renat Akhmerov</div><div>@ Mirantis Inc.</div><div><br></div><br class="Apple-interchange-newline">
</div>
<br><div><div>On 31 May 2014, at 04:26, W Chan <<a href="mailto:m4d.coder@gmail.com">m4d.coder@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Is there an existing unit test for testing enabling keystone middleware in pecan (setting cfg.CONF.pecan.auth_enable = True)? I don't seem to find one. If there's one, it's not obvious. Can someone kindly point me to it?</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 28, 2014 at 9:53 AM, W Chan <span dir="ltr"><<a href="mailto:m4d.coder@gmail.com" target="_blank">m4d.coder@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Thanks for following up. I will publish this change as a separate patch from my current config cleanup.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 28, 2014 at 2:38 AM, Renat Akhmerov <span dir="ltr"><<a href="mailto:rakhmerov@mirantis.com" target="_blank">rakhmerov@mirantis.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br>
On 28 May 2014, at 13:51, Angus Salkeld <<a href="mailto:angus.salkeld@RACKSPACE.COM" target="_blank">angus.salkeld@RACKSPACE.COM</a>> wrote:<br>
<br>
> -----BEGIN PGP SIGNED MESSAGE-----<br>
> Hash: SHA1<br>
><br>
> On 17/05/14 02:48, W Chan wrote:<br>
>> Regarding config opts for keystone, the keystoneclient middleware already<br>
>> registers the opts at<br>
>> <a href="https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L325" target="_blank">https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L325</a><br>
>> under a keystone_authtoken group in the config file. Currently, Mistral<br>
>> registers the opts again at<br>
>> <a href="https://github.com/stackforge/mistral/blob/master/mistral/config.py#L108" target="_blank">https://github.com/stackforge/mistral/blob/master/mistral/config.py#L108</a> under a<br>
>> different configuration group. Should we remove the duplicate from Mistral and<br>
>> refactor the reference to keystone configurations to the keystone_authtoken<br>
>> group? This seems more consistent.<br>
><br>
> I think that is the only thing that makes sense. Seems like a bug<br>
> waiting to happen having the same options registered twice.<br>
><br>
> If some user used to other projects comes and configures<br>
> "keystone_authtoken" then will their config take effect?<br>
> (how much confusion will that generate)..<br>
><br>
> I'd suggest just using the one that is registered keystoneclient.<br>
<br>
</div>Ok, I had a feeling it was needed for some reason. But after having another look at this I think this is really a bug. Let’s do it.<br>
<br>
Thanks guys<br>
<div>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote></div><br></div></body></html>