<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>Our phase 1 of spawn refactor merged a week or 2 ago and we are hard at work on phase 2 and 3. The patch set has been posted. Here is the list in order to review for your convenience</div>
<div><br>
</div>
<div><span style="font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">not a refactor by a trivial fix to clean up some code before the refactor</span></div>
<div>
<div id="magicdomid8" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd url" style="margin: 0px; padding: 1px 0px; cursor: auto;"><a href="https://review.openstack.org/#/c/99238" style="margin: 0px; padding: 0px; cursor: pointer !important;">https://review.openstack.org/#/c/99238</a></span><span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"> </span></div>
<div id="magicdomid8" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"><br>
</span></div>
<div id="magicdomid8" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;">Phase 2 – these are ready for review</span></div>
<div id="magicdomid9" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd url" style="margin: 0px; padding: 1px 0px; cursor: auto;"><a href="https://review.openstack.org/#/c/98285" style="margin: 0px; padding: 0px; cursor: pointer !important;">https://review.openstack.org/#/c/98285</a></span><span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"> (DatastorePath
class) </span></div>
<div id="magicdomid10" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd url" style="margin: 0px; padding: 1px 0px; cursor: auto;"><a href="https://review.openstack.org/#/c/99427" style="margin: 0px; padding: 0px; cursor: pointer !important;">https://review.openstack.org/#/c/99427</a></span><span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"> (Datatore
classs) </span></div>
<div id="magicdomid11" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd url" style="margin: 0px; padding: 1px 0px; cursor: auto;"><a href="https://review.openstack.org/#/c/87002" style="margin: 0px; padding: 0px; cursor: pointer !important;">https://review.openstack.org/#/c/87002</a></span><span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"> (get_image_properties) </span></div>
<div id="magicdomid11" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"><br>
</span></div>
<div id="magicdomid11" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;">Phase 3 - </span>This set is still undergoing some further decomposition. But early (even just high level) comments on the approach, the extent/granularity
of the unit testing will be most welcome. </div>
<div id="magicdomid11" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
Also, trying to break the big patch into smaller self-contained ones is turning out to be quite a challenge. Recommendations on how we can do this sanely most appreciated as well.</div>
<div id="magicdomid12" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd url" style="margin: 0px; padding: 1px 0px; cursor: auto;"><a href="https://review.openstack.org/#/c/98322" style="margin: 0px; padding: 0px; cursor: pointer !important;">https://review.openstack.org/#/c/98322</a></span><span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"> (image
fetching/processing/use) </span></div>
<div id="magicdomid12" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"><br>
</span></div>
<div id="magicdomid12" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"><br>
</span></div>
<div id="magicdomid12" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;">Related review - </span></div>
<div id="magicdomid20" class="" style="margin: 0px; padding: 0px 1px 0px 0px; font-family: Arial, sans-serif; font-size: 12px; line-height: 16px;">
<span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd url" style="margin: 0px; padding: 1px 0px; cursor: auto;"><a href="https://review.openstack.org/#/c/98529/" style="margin: 0px; padding: 0px; cursor: pointer !important;">https://review.openstack.org/#/c/98529/</a></span><span class="author-a-hmdhbfaz66zz77zz85zz82zowkz74zd" style="margin: 0px; padding: 1px 0px; cursor: auto;"> (somewhat
orthogonal, more like a bit of new feature, but came out of the get_image_properties work is the descriptor-based validation of fields in the VMwareImage object) </span></div>
</div>
</body>
</html>