<div dir="ltr">Hi!<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 13, 2014 at 9:30 AM, Day, Phil <span dir="ltr"><<a href="mailto:philip.day@hp.com" target="_blank">philip.day@hp.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div lang="EN-US" link="#0563C1" vlink="#954F72">
<div>
<p class="MsoNormal">Hi Folks,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">A recent change introduced a unit test to “warn/notify developers” when they make a change which will break the out of tree Ironic virt driver:
<a href="https://review.openstack.org/#/c/98201" target="_blank">https://review.openstack.org/#/c/98201</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Ok – so my change (<a href="https://review.openstack.org/#/c/68942" target="_blank">https://review.openstack.org/#/c/68942</a>) broke it as it adds some extra parameters to the virt drive power_off() method – and so I now feel suitable warned and notified
– but am not really clear what I’m meant to do next.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">So far I’ve:<u></u><u></u></p>
<p style="margin-left:54pt">
<u></u><span>-<span style="font-style:normal;font-variant:normal;font-weight:normal;font-size:7pt;line-height:normal;font-family:'Times New Roman'">
</span></span><u></u>Modified the unit test in my Nova patch so it now works<u></u><u></u></p>
<p style="margin-left:54pt">
<u></u><span>-<span style="font-style:normal;font-variant:normal;font-weight:normal;font-size:7pt;line-height:normal;font-family:'Times New Roman'">
</span></span><u></u>Submitted an Ironic patch to add the extra parameters (<a href="https://review.openstack.org/#/c/99932/" target="_blank">https://review.openstack.org/#/c/99932/</a>)<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">As far as I can see there’s no way to create a direct dependency from the Ironic change to my patch – so I guess its down to the Ironic folks to wait and accept it in the correct sequence ?</p></div>
</div></blockquote><div> </div></div><div class="gmail_extra">Thanks for bringing up this question.</div><div class="gmail_extra"><br></div>98201 was added at the suggestion of Sean Dague during a conversation</div><div class="gmail_extra">
in #openstack-infra to help prevent terrible breakages that affect the gate.</div><div class="gmail_extra">What wasn't discussed, however, is how we should coordinate these changes</div><div class="gmail_extra">going forward.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">As for your change, I think what you've done is exactly what we had hoped would</div><div class="gmail_extra">be done. In your particular case, I don't see any need for Nova dev's to not go ahead</div>
<div class="gmail_extra">and approve 68942 *before* 99932 since defaults are added to the arguments. The</div><div class="gmail_extra">question is, how do we coordinate such changes if a change DOES actually break</div><div class="gmail_extra">
ironic?</div><div class="gmail_extra"><br></div><div class="gmail_extra">One suggestion is that if <a class="" href="https://review.openstack.org/#/c/68942/15/nova/tests/virt/test_ironic_api_contracts.py" style="text-decoration:none;font-family:sans-serif;white-space:nowrap;color:rgb(34,34,34)!important;background-image:none!important">test_ironic_api_contracts.py</a> is ever changed, Nova require</div>
<div class="gmail_extra">the Ironic PTL (or a core dev) to vote before approving. That seems sensible to me.</div><div class="gmail_extra"><div>There might be an easier way of coordinating that I'm overlooking, though.</div>
<div><br></div><div>-Dave</div><div dir="ltr"><div>--<br></div>David Shrewsbury (Shrews)<br></div>
</div></div>