<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 29, 2014 at 10:46 AM, Matt Riedemann <span dir="ltr"><<a href="mailto:mriedem@linux.vnet.ibm.com" target="_blank">mriedem@linux.vnet.ibm.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br>
On 5/27/2014 4:44 PM, Vishvananda Ishaya wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I’m not sure that this is the right approach. We really have to add the old extension back for compatibility, so it might be best to simply keep that extension instead of adding a new way to do it.<br>
<br>
Vish<br>
<br>
On May 27, 2014, at 1:31 PM, Cazzolato, Sergio J <<a href="mailto:sergio.j.cazzolato@intel.com" target="_blank">sergio.j.cazzolato@intel.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I have created a blueprint to add this functionality to nova.<br>
<br>
<a href="https://review.openstack.org/#/c/94519/" target="_blank">https://review.openstack.org/#<u></u>/c/94519/</a><br>
<br>
<br>
-----Original Message-----<br>
From: Vishvananda Ishaya [mailto:<a href="mailto:vishvananda@gmail.com" target="_blank">vishvananda@gmail.com</a>]<br>
Sent: Tuesday, May 27, 2014 5:11 PM<br>
To: OpenStack Development Mailing List (not for usage questions)<br>
Subject: Re: [openstack-dev] [nova] nova default quotas<br>
<br>
Phil,<br>
<br>
You are correct and this seems to be an error. I don't think in the earlier ML thread[1] that anyone remembered that the quota classes were being used for default quotas. IMO we need to revert this removal as we (accidentally) removed a Havana feature with no notification to the community. I've reactivated a bug[2] and marked it critcal.<br>
<br>
Vish<br>
<br>
[1] <a href="http://lists.openstack.org/pipermail/openstack-dev/2014-February/027574.html" target="_blank">http://lists.openstack.org/<u></u>pipermail/openstack-dev/2014-<u></u>February/027574.html</a><br>
[2] <a href="https://bugs.launchpad.net/nova/+bug/1299517" target="_blank">https://bugs.launchpad.net/<u></u>nova/+bug/1299517</a><br>
<br>
On May 27, 2014, at 12:19 PM, Day, Phil <<a href="mailto:philip.day@hp.com" target="_blank">philip.day@hp.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Vish,<br>
<br>
I think quota classes have been removed from Nova now.<br>
<br>
Phil<br>
<br>
<br>
Sent from Samsung Mobile<br>
<br>
<br>
-------- Original message --------<br>
From: Vishvananda Ishaya<br>
Date:27/05/2014 19:24 (GMT+00:00)<br>
To: "OpenStack Development Mailing List (not for usage questions)"<br>
Subject: Re: [openstack-dev] [nova] nova default quotas<br>
<br>
Are you aware that there is already a way to do this through the cli using quota-class-update?<br>
<br>
<a href="http://docs.openstack.org/user-guide-admin/content/cli_set_quotas.html" target="_blank">http://docs.openstack.org/<u></u>user-guide-admin/content/cli_<u></u>set_quotas.html</a> (near the bottom)<br>
<br>
Are you suggesting that we also add the ability to use just regular quota-update? I'm not sure i see the need for both.<br>
<br>
Vish<br>
<br>
On May 20, 2014, at 9:52 AM, Cazzolato, Sergio J <<a href="mailto:sergio.j.cazzolato@intel.com" target="_blank">sergio.j.cazzolato@intel.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I would to hear your thoughts about an idea to add a way to manage the default quota values through the API.<br>
<br>
The idea is to use the current quota api, but sending ''default' instead of the tenant_id. This change would apply to quota-show and quota-update methods.<br>
<br>
This approach will help to simplify the implementation of another blueprint named per-flavor-quotas<br>
<br>
Feedback? Suggestions?<br>
<br>
<br>
Sergio Juan Cazzolato<br>
Intel Software Argentina<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</blockquote>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</blockquote>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</blockquote>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
<br>
</blockquote>
<br></div></div>
The reverted series for nova on master is here [1].<br></blockquote><div><br></div><div>I don't think we want a full revert here, the feature that we broke is the ability to easily update the default quota values without restarting any services, not quota-classes themselves. Given that I see 3 paths forward:</div>
<div><br></div><div>1. Provide an alternate way to do this. OpenStack already has an implicit assumption that one has a way of rolling out config files across all machines. so we can teach oslo.config to know which config options can be updated without a restart. Â While this definitely breaks the API, this is a rarely used API and we can avoid breaking functionality at least.</div>
<div>2. Do a partial revert of this API to only support overriding the default quota values. Hopefully while doing this we can simplify the quota logic and reduce the number of DB calls needed. This way we can restore the working part of the API and not the unimplemented quota-class logic itself.</div>
<div>3. Do a full revert and re-add all the unimplemented quota-class logic, we now have just re-added a non-working API.</div><div><br></div><div>While I would prefer to take path 1 as I think that gets us closer to where we should be, I think path 2 is safer approach.</div>
<div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Once that's merged I can work on backporting the revert for the API change to stable/icehouse, which will be a little tricky given conflicts from master.<br>
<br>
[1] <a href="https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:restore-quota-class,n,z" target="_blank">https://review.openstack.org/#<u></u>/q/status:open+project:<u></u>openstack/nova+branch:master+<u></u>topic:restore-quota-class,n,z</a><span class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
<br>
Thanks,<br>
<br>
Matt Riedemann</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>