<html><body>
<p><font size="2" face="sans-serif">Would it be feasible to make the retry logic only apply to read-only operations? This would still require a nova change to specify the number of retries, but it'd also prevent invokers from shooting themselves in the foot if they call for a write operation.<br>
<br>
</font><br>
<br>
<tt><font size="2">Aaron Rosen <aaronorosen@gmail.com> wrote on 05/27/2014 09:40:00 PM:<br>
<br>
> From: Aaron Rosen <aaronorosen@gmail.com></font></tt><br>
<tt><font size="2">> To: "OpenStack Development Mailing List (not for usage questions)" <br>
> <openstack-dev@lists.openstack.org>, </font></tt><br>
<tt><font size="2">> Date: 05/27/2014 09:44 PM</font></tt><br>
<tt><font size="2">> Subject: Re: [openstack-dev] [neutron] Supporting retries in neutronclient</font></tt><br>
<tt><font size="2">> <br>
> Hi, </font></tt><br>
<tt><font size="2">> <br>
> Is it possible to detect when the ssl handshaking error occurs on <br>
> the client side (and only retry for that)? If so I think we should <br>
> do that rather than retrying multiple times. The danger here is <br>
> mostly for POST operations (as Eugene pointed out) where it's <br>
> possible for the response to not make it back to the client and for <br>
> the operation to actually succeed. </font></tt><br>
<tt><font size="2">> <br>
> Having this retry logic nested in the client also prevents things <br>
> like nova from handling these types of failures individually since <br>
> this retry logic is happening inside of the client. I think it would<br>
> be better not to have this internal mechanism in the client and <br>
> instead make the user of the client implement retry so they are <br>
> aware of failures. </font></tt><br>
<tt><font size="2">> <br>
> Aaron </font></tt><br>
<tt><font size="2">> <br>
</font></tt><br>
<tt><font size="2">> On Tue, May 27, 2014 at 10:48 AM, Paul Ward <wpward@us.ibm.com> wrote:</font></tt><br>
<tt><font size="2">> Currently, neutronclient is hardcoded to only try a request once in <br>
> retry_request by virtue of the fact that it uses self.retries as the<br>
> retry count, and that's initialized to 0 and never changed. We've <br>
> seen an issue where we get an ssl handshaking error intermittently <br>
> (seems like more of an ssl bug) and a retry would probably have <br>
> worked. Yet, since neutronclient only tries once and gives up, it <br>
> fails the entire operation. Here is the code in question:<br>
> <br>
> <a href="https://github.com/openstack/python-neutronclient/blob/master/">https://github.com/openstack/python-neutronclient/blob/master/</a><br>
> neutronclient/v2_0/client.py#L1296<br>
> <br>
> Does anybody know if there's some explicit reason we don't currently<br>
> allow configuring the number of retries? If not, I'm inclined to <br>
> propose a change for just that.</font></tt><br>
<tt><font size="2">> <br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> OpenStack-dev@lists.openstack.org<br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</font></tt><br>
<tt><font size="2">> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> OpenStack-dev@lists.openstack.org<br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</font></tt></body></html>