<div dir="ltr"><div><div><div>Hello, <br><br></div><div>One small remark:<br></div>"Work in Progress" can be set only by change owners (defined in All-Projects ACLs) which could be a limitation when multiple people contribute to the same change.<br>
<br><br></div>Cedric <br></div>ZZelle@IRC<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 22, 2014 at 1:43 PM, Sergey Lukjanov <span dir="ltr"><<a href="mailto:slukjanov@mirantis.com" target="_blank">slukjanov@mirantis.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Great, I think it'll make CRs more consistent, especially from the<br>
reviewers PoV.<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, May 22, 2014 at 3:24 AM, Clark Boylan <<a href="mailto:clark.boylan@gmail.com">clark.boylan@gmail.com</a>> wrote:<br>
> Hello everyone,<br>
><br>
> Gerrit has long supported "Draft" patchsets, and the infra team has long<br>
> recommended against using them as they are a source of bugs and<br>
> confusion (see below for specific details if you are curious). The newer<br>
> version of Gerrit that we recently upgraded to allows us to prevent<br>
> people from pushing new Draft patchsets. We will take advantage of this<br>
> and disable pushes of new Drafts on Friday May 30, 2014.<br>
><br>
> The impact of this change should be small. You can use the Work in<br>
> Progress state instead of Drafts for new patchsets. Any existing<br>
> Draft patchsets will remain in a Draft state until it is published.<br>
><br>
> Now for the fun details on why drafts are broken.<br>
><br>
> * Drafts appear to be "secure" but they offer no security. This is bad<br>
> for user expectations and may expose data that shouldn't be exposed.<br>
> * Draft patchsets pushed after published patchsets confuse reviewers as<br>
> they cannot vote with a value because the latest patchset is hidden.<br>
> * Draft patchsets confuse the Gerrit event stream output making it<br>
> difficult for automated tooling to do the correct thing with Drafts.<br>
> * Child changes of Drafts will fail to merge without explanation.<br>
><br>
> Let us know if you have any questions,<br>
><br>
> Clark (on behalf of the infra team)<br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Sincerely yours,<br>
Sergey Lukjanov<br>
Sahara Technical Lead<br>
(OpenStack Data Processing)<br>
Mirantis Inc.<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div>