<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; ">
<div>
<div>
<div>Hi everyone,</div>
<div><br>
</div>
<div>I've been looking at two reviews that Ann Kamyshnikova has proposed </div>
<div><br>
</div>
<div><a href="https://review.openstack.org/#/c/82073">https://review.openstack.org/#/c/82073</a>/</div>
<div><br>
</div>
<div><a href="https://review.openstack.org/#/c/80518">https://review.openstack.org/#/c/80518</a>/ </div>
<div><br>
</div>
<div>I think the changes are fundamentally a Good Thing™ - they appear to reduce the differences between the database models and their corresponding migrations – as well as fixing differences in the generated DDL between Postgres and MySQL. </div>
<div><br>
</div>
<div>The only thing I'm concerned about, is how to prevent these inconsistencies from sneaking into the codebase in the future. The one review that fixes ForeignKey constraints that are missing a name argument which ends up failing to create indexes in Postgres
– I can see myself repeating that mistake, it's very subtle.</div>
<div><br>
</div>
<div>Should we have some sort of HACKING for database models and migrations? Are these problems subtle enough that they warrant changes to SQLAlchemy/Alembic?</div>
<div><br>
</div>
<div>
<div>
<div>
<div>-- </div>
</div>
<div>
<div>Sean M. Collins</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>