<div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">If scaling becomes the issue, you can always do review at sub-team level with at least two cores in each review meeting (say neutron-parity, ML2, Services, LBaaS, etc). But probably best to start with one meeting and hit that scale issue first.</div>
<div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Regards,</div><div class="gmail_default" style="font-size:small">Mandeep</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Mon, Apr 21, 2014 at 9:20 AM, Akihiro Motoki <span dir="ltr"><<a href="mailto:amotoki@gmail.com" target="_blank">amotoki@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
Previously Neutron team had ReviewDays [1] and core members made themselves<br>
focus on reviews and be available on IRC channel one or more day(s) of each week<br>
(as possible as they can).<br>
<br>
The number of neutron reviews has increased compared to that time and<br>
I am afraid one or two days reviews cannot deal with neutron reviews, but<br>
the similar mechanism might work to make things better.<br>
<br>
[1] <a href="https://wiki.openstack.org/wiki/Neutron/ReviewDays" target="_blank">https://wiki.openstack.org/wiki/Neutron/ReviewDays</a><br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Tue, Apr 22, 2014 at 12:54 AM, <a href="mailto:marios@redhat.com">marios@redhat.com</a> <<a href="mailto:mandreou@redhat.com">mandreou@redhat.com</a>> wrote:<br>
> On 21/04/14 18:29, Kyle Mestery wrote:<br>
>> On Mon, Apr 21, 2014 at 9:38 AM, <a href="mailto:marios@redhat.com">marios@redhat.com</a> <<a href="mailto:mandreou@redhat.com">mandreou@redhat.com</a>> wrote:<br>
>>> Hi,<br>
>>><br>
>>> I think both PTL candidates mentioned process improvements wrt<br>
>>> contributions and reviews in their candidacy announcements. As a new<br>
>>> Neutron dev I have seen that it is easy for reviews to go unnoticed,<br>
>>> especially when they are stand-alone bug fixes that aren't part of a<br>
>>> particular blueprint group (and so aren't discussed/highlighted at the<br>
>>> various sub-team meetings). Of course this is also compounded by a<br>
>>> seemingly heavy backlog of reviews. I realise that all core/non-core<br>
>>> devs are doing as much as they can and though more cores will help, it<br>
>>> takes a long time to develop people into this role.<br>
>>><br>
>>> I was wondering if a 'review hour' would help. This is something Lucas<br>
>>> Gomez told me about; the Ironic core team has a weekly hour slot in<br>
>>> which they discuss x number of reviews and approve or -1 them. Besides<br>
>>> getting reviews cleared quicker, it also opens the process up. It will<br>
>>> allow new contributors to (more quickly) learn about the kinds of things<br>
>>> core reviewers look for in a patch and also give real-time feedback<br>
>>> (e.g. could just use #openstack-neutron for discussion during the hour).<br>
>>> I feel that this could have an impact on the review backlog even if this<br>
>>> only tackling the oldest 5 reviews for example.<br>
>>><br>
>>> Do any of the core devs think this would be a good thing, and do you<br>
>>> think you have the time for it?<br>
>>><br>
>> This is an interesting idea Marios, thanks for proposing it! Are you<br>
>> saying we should have a "Review Hour" on IRC, where we walk through XX<br>
>> number of reviews as a team? That's an interesting idea actually, and<br>
>> I'd be in favor of something like this. We could rotate timeslots so<br>
>> as to get everyone on the team (both core and non-core) a chance to<br>
>> participate.<br>
>><br>
>> Can you attend our weekly meeting today [1] where we can discuss this as a team?<br>
><br>
> Thanks very much for responding Kyle, I was worried about my message<br>
> sounding 'complainy' - I will try my best to attend the meeting today,<br>
> though it is at midnight here (CET +1hrs) so I typically only get to<br>
> catch up on the logs.<br>
><br>
> Depending on whether others think setting up the "irc review hour" is a<br>
> good idea, one side effect would be that we then have a second 'neutron<br>
> meeting' slot during the week (even if this is only for reviews). If we<br>
> pick this time carefully we could even alternate between 'weekly<br>
> meeting' and 'review meeting' to make it easier for folks in Europe to<br>
> join the weekly meeting (and make it less harsh for people in Asia<br>
> Pacific who have to get up very early for the current slot [1]). Though<br>
> this is of course just speculation and I'm really getting ahead of<br>
> myself (I was going to include this last thought in my original email<br>
> but it was already long enough)<br>
><br>
> thanks, marios<br>
><br>
><br>
> [1] [1]<br>
> <a href="http://www.timeanddate.com/worldclock/meetingtime.html?iso=20140421&p1=137&p2=179&p3=136&p4=37&p5=166&p6=248&p7=196&p8=47" target="_blank">http://www.timeanddate.com/worldclock/meetingtime.html?iso=20140421&p1=137&p2=179&p3=136&p4=37&p5=166&p6=248&p7=196&p8=47</a><br>
><br>
>><br>
>> Thanks!<br>
>> Kyle<br>
>><br>
>> [1] <a href="https://wiki.openstack.org/wiki/Network/Meetings" target="_blank">https://wiki.openstack.org/wiki/Network/Meetings</a><br>
>><br>
>>> thanks, marios<br>
>>><br>
>>> _______________________________________________<br>
>>> OpenStack-dev mailing list<br>
>>> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
>><br>
>> _______________________________________________<br>
>> OpenStack-dev mailing list<br>
>> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div>