<div dir="ltr"><div>Guys,</div><div><br></div><div>We have big and complicated structure of the project. And part of our patchsets require additional actions before merge. Sometimes we need approve from testers, sometimes we need merge requests in several repos at the same time, sometimes we need updates of rpm repositories before merge.</div>
<div><br></div><div>We have informal rule: invite all the required persons to the review. And core reviewer does not merge code if part of +1's are missed. Sad, but this rule is not obvious.</div><div><br></div><div>This informal rule became even more strict when we need update of rpm/deb repositories, because OSCI changes should be accomplished right before merge. For such reviews we ask OSCI team to do changes, checks and merge.</div>
<div><br></div><div><a href="https://review.openstack.org/#/c/86001/">https://review.openstack.org/#/c/86001/</a> This particular request requires check of our 4.1.1 rpm/deb repositories status. Thats why Roman Vyalov is added as reviewer.</div>
<div><br></div><div>I don't like over-bureaucracy. My suggestion is simple: take into account reviewers status and do not merge if unsure.</div><div><br></div></div>