<div dir="ltr">Hi<div><br></div><div>+1 for your proposed -core changes.</div><div><br></div><div>Re your question about whether we should retroactively apply the 3-a-day rule to the 3 month review stats, my suggestion would be a qualified no.</div>
<div><br></div><div>I think we've established an agile approach to the member list of -core, so if there are a one or two people who we would have added to -core before the goalposts moved, I'd say look at their review quality. If they're showing the right stuff, let's get them in and helping. If they don't feel our new goalposts are achievable with their workload, they'll fall out again naturally before long.</div>
<div><br></div><div>Cheers,</div><div><br></div><div>Chris</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 3 April 2014 12:02, Robert Collins <span dir="ltr"><<a href="mailto:robertc@robertcollins.net" target="_blank">robertc@robertcollins.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Getting back in the swing of things...<br>
<br>
Hi,<br>
like most OpenStack projects we need to keep the core team up to<br>
date: folk who are not regularly reviewing will lose context over<br>
time, and new folk who have been reviewing regularly should be trusted<br>
with -core responsibilities.<br>
<br>
In this months review:<br>
- Dan Prince for -core<br>
- Jordan O'Mara for removal from -core<br>
- Jiri Tomasek for removal from -core<br>
- Jamomir Coufal for removal from -core<br>
<br>
Existing -core members are eligible to vote - please indicate your<br>
opinion on each of the three changes above in reply to this email.<br>
<br>
Ghe, please let me know if you're willing to be in tripleo-core. Jan,<br>
Jordan, Martyn, Jiri & Jaromir, if you are planning on becoming<br>
substantially more active in TripleO reviews in the short term, please<br>
let us know.<br>
<br>
My approach to this caused some confusion a while back, so I'm keeping<br>
the boilerplate :) - I'm<br>
going to talk about stats here, but they are only part of the picture<br>
: folk that aren't really being /felt/ as effective reviewers won't be<br>
asked to take on -core responsibility, and folk who are less active<br>
than needed but still very connected to the project may still keep<br>
them : it's not pure numbers.<br>
<br>
Also, it's a vote: that is direct representation by the existing -core<br>
reviewers as to whether they are ready to accept a new reviewer as<br>
core or not. This mail from me merely kicks off the proposal for any<br>
changes.<br>
<br>
But, the metrics provide an easy fingerprint - they are a useful tool<br>
to avoid bias (e.g. remembering folk who are just short-term active) -<br>
human memory can be particularly treacherous - see 'Thinking, Fast and<br>
Slow'.<br>
<br>
With that prelude out of the way:<br>
<br>
Please see Russell's excellent stats:<br>
<a href="http://russellbryant.net/openstack-stats/tripleo-reviewers-30.txt" target="_blank">http://russellbryant.net/openstack-stats/tripleo-reviewers-30.txt</a><br>
<a href="http://russellbryant.net/openstack-stats/tripleo-reviewers-90.txt" target="_blank">http://russellbryant.net/openstack-stats/tripleo-reviewers-90.txt</a><br>
<br>
For joining and retaining core I look at the 90 day statistics; folk<br>
who are particularly low in the 30 day stats get a heads up so they<br>
aren't caught by surprise.<br>
<br>
90 day active-enough stats:<br>
<br>
+-------------------------+---------------------------------------+----------------+<br>
| Reviewer | Reviews -2 -1 +1 +2 +A +/- % |<br>
Disagreements* |<br>
+-------------------------+---------------------------------------+----------------+<br>
| slagle ** | 655 0 145 7 503 154 77.9% |<br>
36 ( 5.5%) |<br>
| clint-fewbar ** | 549 4 120 11 414 115 77.4% |<br>
32 ( 5.8%) |<br>
| lifeless ** | 518 34 203 2 279 113 54.2% |<br>
21 ( 4.1%) |<br>
| rbrady | 453 0 14 439 0 0 96.9% |<br>
60 ( 13.2%) |<br>
| cmsj ** | 322 0 24 1 297 136 92.5% |<br>
22 ( 6.8%) |<br>
| derekh ** | 261 0 50 1 210 90 80.8% |<br>
12 ( 4.6%) |<br>
| dan-prince | 257 0 67 157 33 16 73.9% |<br>
15 ( 5.8%) |<br>
| jprovazn ** | 190 0 21 2 167 43 88.9% |<br>
13 ( 6.8%) |<br>
| ifarkas ** | 186 0 28 18 140 82 84.9% |<br>
6 ( 3.2%) |<br>
===========================================================<br>
| jistr ** | 177 0 31 16 130 28 82.5% |<br>
4 ( 2.3%) |<br>
| ghe.rivero ** | 176 1 21 25 129 55 87.5% |<br>
7 ( 4.0%) |<br>
| lsmola ** | 172 2 12 55 103 63 91.9% |<br>
21 ( 12.2%) |<br>
| jdob | 166 0 31 135 0 0 81.3% |<br>
9 ( 5.4%) |<br>
| bnemec | 138 0 38 100 0 0 72.5% |<br>
17 ( 12.3%) |<br>
| greghaynes | 126 0 21 105 0 0 83.3% |<br>
22 ( 17.5%) |<br>
| dougal | 125 0 26 99 0 0 79.2% |<br>
13 ( 10.4%) |<br>
| tzumainn ** | 119 0 30 69 20 17 74.8% |<br>
2 ( 1.7%) |<br>
| rpodolyaka | 115 0 15 100 0 0 87.0% |<br>
15 ( 13.0%) |<br>
| ftcjeff | 103 0 3 100 0 0 97.1% |<br>
9 ( 8.7%) |<br>
| thesheep | 93 0 26 31 36 21 72.0% |<br>
3 ( 3.2%) |<br>
| pblaho ** | 88 1 8 37 42 22 89.8% |<br>
3 ( 3.4%) |<br>
| jonpaul-sullivan | 80 0 33 47 0 0 58.8% |<br>
17 ( 21.2%) |<br>
| tomas-8c8 ** | 78 0 15 4 59 27 80.8% |<br>
4 ( 5.1%) |<br>
| marios ** | 75 0 7 53 15 10 90.7% |<br>
14 ( 18.7%) |<br>
| stevenk | 75 0 15 60 0 0 80.0% |<br>
9 ( 12.0%) |<br>
| rwsu | 74 0 3 71 0 0 95.9% |<br>
11 ( 14.9%) |<br>
| mkerrin | 70 0 14 56 0 0 80.0% |<br>
14 ( 20.0%) |<br>
<br>
The ==== line is set at the just voted on minimum expected of core: 3<br>
reviews per work day, 60 work days in a 90 day period (64 - fudge for<br>
holidays), 180 reviews.<br>
I cut the full report out at the point we had been previously - with<br>
the commitment to 3 reviews per day, next months report will have a<br>
much higher minimum. In future reviews, we'll set the bar up around<br>
where the === is - but of course, human judgement will always apply<br>
:).<br>
<br>
<br>
rbrady is a very active review - which is fantastic. However I'd like<br>
to see deeper thought - when I reviewed his reviews there were often<br>
things missed (which the disagreements % above does capture to a bit,<br>
but since its per-patch, I'm not sure the metric is sufficient - but<br>
thats a different discussion.<br>
<br>
Dan has got much deeper in in his reviews and I now would be delighted<br>
to have him in core.<br>
<br>
Bnemec, jdob, greg etc - good stuff, I value your reviews already, but<br>
since we've now set a commitment for cores - I'm not sure if we should<br>
offer core to folk who aren't up at the 180 line - core. What do folk<br>
think? I'd certainly have been nominating at least one more person if<br>
we hadn't recently moved the goalposts...<br>
<br>
<br>
And the 90 day not-active-enough status:<br>
<br>
| jtomasek ** | 24 0 2 15 7 3 91.7% |<br>
0 ( 0.0%) |<br>
| jomara ** | 22 0 5 8 9 11 77.3% |<br>
0 ( 0.0%) |<br>
| jcoufal ** | 12 0 3 6 3 3 75.0% |<br>
2 ( 16.7%) |<br>
<br>
As we discussed last time - I propose we remove these folk from core -<br>
they are still contributing, but core is primarily a responsibility -<br>
and folk can step back up as core very quickly if they want to.<br>
<br>
Now, 30 day history - this is the heads up for folk to avoid surprises<br>
in April. For this, I've used the new commitment of 3 per day - or 60<br>
per 30 day window (same math as above).<br>
<br>
Folk that are on track to retain/ be asked to be -core (on volume, not<br>
quality- thats looked in detail later):<br>
<br>
| slagle ** | 205 0 46 5 154 40 77.6% |<br>
9 ( 4.4%) |<br>
| lifeless ** | 204 13 98 0 93 42 45.6% |<br>
4 ( 2.0%) |<br>
| clint-fewbar ** | 197 4 55 6 132 31 70.1% |<br>
10 ( 5.1%) |<br>
| rbrady | 147 0 7 140 0 0 95.2% |<br>
20 ( 13.6%) |<br>
| derekh ** | 111 0 26 0 85 33 76.6% |<br>
5 ( 4.5%) |<br>
| cmsj ** | 91 0 9 0 82 39 90.1% |<br>
4 ( 4.4%) |<br>
| dan-prince | 89 0 30 46 13 6 66.3% |<br>
6 ( 6.7%) |<br>
| greghaynes | 84 0 18 66 0 0 78.6% |<br>
9 ( 10.7%) |<br>
| rpodolyaka | 80 0 12 68 0 0 85.0% |<br>
11 ( 13.8%) |<br>
| jonpaul-sullivan | 77 0 31 46 0 0 59.7% |<br>
17 ( 22.1%) |<br>
| bnemec | 72 0 23 49 0 0 68.1% |<br>
7 ( 9.7%) |<br>
| jprovazn ** | 65 0 13 0 52 9 80.0% |<br>
9 ( 13.8%) |<br>
| lsmola ** | 65 0 6 14 45 23 90.8% |<br>
6 ( 9.2%) |<br>
| ghe.rivero ** | 63 1 11 10 41 20 81.0% |<br>
3 ( 4.8%) |<br>
| mkerrin | 60 0 10 50 0 0 83.3% |<br>
12 ( 20.0%) |<br>
| ifarkas ** | 60 0 7 1 52 30 88.3% |<br>
1 ( 1.7%) |<br>
| jistr ** | 58 0 5 7 46 13 91.4% |<br>
1 ( 1.7%) |<br>
<br>
<br>
-core that are not keeping up recently... :<br>
<br>
| tomas-8c8 ** | 31 0 4 2 25 8 87.1% |<br>
1 ( 3.2%) |<br>
| marios ** | 27 0 1 17 9 7 96.3% |<br>
3 ( 11.1%) |<br>
| tzumainn ** | 27 0 3 23 1 4 88.9% |<br>
0 ( 0.0%) |<br>
| pblaho ** | 17 0 0 4 13 4 100.0% |<br>
1 ( 5.9%) |<br>
| jomara ** | 0 0 0 0 0 1 0.0% |<br>
0 ( 0.0%) |<br>
<br>
<br>
Please remember - the stats are just an entry point to a more detailed<br>
discussion about each individual, and I know we all have a bunch of<br>
work stuff, on an ongoing basis :)<br>
<br>
I'm using the fairly simple metric we agreed on - 'average at least<br>
three reviews a<br>
day' as a proxy for 'sees enough of the code and enough discussion of<br>
the code to be an effective reviewer'. The three review a day thing we<br>
derived based<br>
on the need for consistent volume of reviews to handle current<br>
contributors - we may<br>
lower that once we're ahead (which may happen quickly if we get more cores... :)<br>
But even so:<br>
- reading three patches a day is a pretty low commitment to ask for<br>
- if you don't have time to do that, you will get stale quickly -<br>
you'll only see under<br>
33% of the code changes going on (we're doing about 10 commits<br>
a day - twice as many since december - and hopefully not slowing down!)<br>
<br>
Cheers,<br>
Rob<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
Robert Collins <<a href="mailto:rbtcollins@hp.com">rbtcollins@hp.com</a>><br>
Distinguished Technologist<br>
HP Converged Cloud<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Cheers,<div><br></div><div>Chris</div></div>
</div>