<div dir="ltr"><div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Mar 25, 2014 at 10:19 AM, Russell Bryant <span dir="ltr"><<a href="mailto:rbryant@redhat.com" target="_blank">rbryant@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">On 03/25/2014 10:42 AM, Steven Sonnenberg wrote:<br>
> I just want to point out, there were no changes required to pass the tests. We were running those tests in Brazil and tunneling NFS and iSCSI across the Internet which explain timeout issues. Those are the same tests that passed a month earlier before we went into the cycle of review/fix/format etc.<br>
<br>
</div>I think the key point is the current timing. We're aiming to do RC1 for<br>
projects this week if possible. FFEs were really only allowed weeks ago.<br>
<span class=""><font color="#888888"><br>
--<br>
Russell Bryant<br>
</font></span><div class=""><div class="h5"><br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><div class="gmail_default" style="font-family:'courier new',monospace">Hey Steven,</div><div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">
As we discussed last night, my issue is that it's just very late at this point. Yes, your patch has been in review for 45 days, however even then it was pushing it. By the way 45 days at this stage of the release is not a long time. My question is if people have been running this since HongKong why did you wait until February before submitting it?</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">It is minimal risk to the core code, no doubt. However, I've taking a pretty hard stance with other 3'rd party drivers that have missed the cut off dates and I don't see a compelling reason to make an exception here based just on principal.</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">I'd also like to point out that contributions help when it comes to FFE's. In other words I don't see any activity other than this driver for the last 4 months (reviews or otherwise). When somebody comes in with a patch past a date and asks for an exception the first thing I consider is whether they've been active for the cycle or if they're just racing the clock to get a driver in for the next release.</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">Something else I consider is if current code is maintained, in other words you have a driver in the code base currently and it hasn't been maintained since August (again last minute fixes before RC). Now during RC you have another driver that you want added. If there was active involvement and maintenance of the code and I didn't see a pattern here (pattern of late/last minute submission) I likely would have a different opinion.</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">I'm still a -1 on the exception, even if it inherently doesn't introduce significant risk. It's not the code or the driver itself at this point but the point regarding dates, process etc.</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">[1] History of maintenance for existing HDS code in Cinder</div>
<div class="gmail_default" style="font-family:'courier new',monospace">[2] Commit history for Erlon (author of the current patch/driver)</div><div class="gmail_default" style="font-family:'courier new',monospace">
[3] Commit history for the author of the previous driver including the last minute updates</div><div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">
Thanks,</div><div class="gmail_default" style="font-family:'courier new',monospace">John</div><br></div><div class="gmail_extra"><div class="gmail_default" style="font-family:'courier new',monospace;display:inline">
[1]: </div><a href="https://github.com/openstack/cinder/commits/master/cinder/volume/drivers/hds">https://github.com/openstack/cinder/commits/master/cinder/volume/drivers/hds</a><br></div><div class="gmail_extra"><div class="gmail_default" style="font-family:'courier new',monospace;display:inline">
[2]: </div><a href="https://review.openstack.org/#/dashboard/10058">https://review.openstack.org/#/dashboard/10058</a><br></div><div class="gmail_extra"><div class="gmail_default" style="font-family:'courier new',monospace;display:inline">
[3]: </div><a href="https://review.openstack.org/#/dashboard/7447">https://review.openstack.org/#/dashboard/7447</a><br></div></div>