<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Sean Dague <sean@dague.net></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">"OpenStack Development
Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org>,
</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">03/07/2014 04:25 AM</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [openstack-dev]
[Nova] FFE Request: Oslo: i18n Message improvements</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>On 03/06/2014 04:46 PM, James Carey wrote:<br>
> Please consider a FFE for i18n Message improvements:
<br>
> BP: </font></tt><a href="https://blueprints.launchpad.net/nova/+spec/i18n-messages"><tt><font size=2>https://blueprints.launchpad.net/nova/+spec/i18n-messages</font></tt></a><tt><font size=2><br>
> <br>
> The base enablement for lazy translation has already
been sync'd<br>
> from oslo. This patch was to enable lazy translation support
in Nova.<br>
> It is titled re-enable lazy translation because this was enabled
during<br>
> Havana but was pulled due to issues that have since been resolved.<br>
> <br>
> In order to enable lazy translation it is necessary
to do the<br>
> following things:<br>
> <br>
> (1) Fix a bug in oslo with respect to how keywords are extracted
from<br>
> the format strings when saving replacement text for use when the message<br>
> translation is done. This is<br>
> </font></tt><a href="https://bugs.launchpad.net/nova/+bug/1288049"><tt><font size=2>https://bugs.launchpad.net/nova/+bug/1288049</font></tt></a><tt><font size=2>,
which I'm actively working<br>
> on a fix for in oslo. Once that is complete it will need to
be sync'd<br>
> into nova.<br>
> <br>
> (2) Remove concatenation (+) of translatable messages. The
current<br>
> class that is used to hold the translatable message<br>
> (gettextutils.Message) does not support concatenation. There
were a few<br>
> cases in Nova where this was done and they are coverted to other means<br>
> of combining the strings in:<br>
> </font></tt><a href=https://review.openstack.org/#/c/78095Remove><tt><font size=2>https://review.openstack.org/#/c/78095Remove</font></tt></a><tt><font size=2>
use of concatenation on<br>
> messages<br>
> <br>
> (3) Remove the use of str() on exceptions. The intent
of this is to<br>
> return the message contained in the exception, but these messages
may<br>
> contain unicode, so str cannot be used on them and gettextutils.Message<br>
> enforces this. Thus these need<br>
> to either be removed and allow python formatting to do the right thing,<br>
> or changed to unicode(). Since unicode() will change to str()
in Py3,<br>
> the forward compatible six.text_type() is used instead. This
is done in: <br>
> </font></tt><a href=https://review.openstack.org/#/c/78096Remove><tt><font size=2>https://review.openstack.org/#/c/78096Remove</font></tt></a><tt><font size=2>
use of str() on exceptions<br>
> <br>
> (4) The addition of the call that enables the use of lazy messages.<br>
> This is in:<br>
> </font></tt><a href="https://review.openstack.org/#/c/73706Re-enable"><tt><font size=2>https://review.openstack.org/#/c/73706Re-enable</font></tt></a><tt><font size=2>
lazy translation.<br>
> <br>
> Lazy translation has been enabled in the other projects
so it would<br>
> be beneficial to be consistent with the other projects with respect
to<br>
> message translation. <br>
<br>
Unless it has landed in *every other* integrated project besides Nova,
I<br>
don't find this compelling.<br>
<br>
I have tested that the changes in (2) and (3) work<br>
> when lazy translation is not enabled. Thus if a problem is found,
the<br>
> two line change in (4) could be removed to get to the previous behavior.<br>
> <br>
> I've been talking to Matt Riedemann and Dan Berrange
about this.<br>
> Matt has agreed to be a sponsor.<br>
<br>
If this is enabled in other projects, where is the Tempest scenario test<br>
that actually demonstrates that this is working on real installs?<br>
<br>
I get that everyone has features that didn't hit. BHowever now is not<br>
that time for that, now is the time for people to get focussed on bugs<br>
hunting. And especially if we are talking about *another* oslo sync.<br>
<br>
-1<br>
<br>
-Sean<br>
<br>
-- <br>
Sean Dague<br>
Samsung Research America<br>
sean@dague.net / sean.dague@samsung.com<br>
</font></tt><a href=http://dague.net/><tt><font size=2>http://dague.net</font></tt></a><tt><font size=2><br>
<br>
[attachment "signature.asc" deleted by Jay S Bryant/Rochester/IBM]
_______________________________________________<br>
OpenStack-dev mailing list<br>
OpenStack-dev@lists.openstack.org<br>
</font></tt><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev"><tt><font size=2>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</font></tt></a><tt><font size=2><br>
</font></tt>
<br><font size=2 face="sans-serif">Sean,</font>
<br>
<br><font size=2 face="sans-serif">I really feel like this is being made
into a bigger deal than it needs to be.</font>
<br>
<br><font size=2 face="sans-serif">The only other project that hasn't accepted
this change is Heat and we are currently working to resolve that issue.</font>
<br>
<br><font size=2 face="sans-serif">We were not aware of a requirement for
Tempest tests for a change like this. We would be willing to work
on getting those added to resolve that issue.</font>
<br><font size=2 face="sans-serif">If we were to get these added ASAP would
you be willing to reconsider?</font>
<br>
<br><font size=2 face="sans-serif">As far as the Oslo sync is concerned,
it is a sync gettextutils which is an isolated module that doesn't have
other dependencies and is pulling in a number of good bug fixes.</font>
<br><font size=2 face="sans-serif">The removal of str() from LOGs and exceptions
was a ticking time bomb that needed to be addressed anyway.</font>
<br>
<br><font size=2 face="sans-serif">The change brings good value for users
and fixes issues that have been lying around for quite some time. We
apologize that this is coming in so late in the game.</font>
<br><font size=2 face="sans-serif">There were extraneous challenges that
lead to the timing on this.</font>
<br>
<br><font size=2 face="sans-serif">Thank you for your consideration on
this issue.</font>
<br>
<br><font size=3><b><i>Jay S. Bryant</i></b><br>
<i>IBM Cinder Subject Matter Expert
& Cinder Core Member</i></font>