<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<base target="_blank"><!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:宋体;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@宋体";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:宋体;
mso-believe-normal-left:yes;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"纯文本 Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.Char
{mso-style-name:"纯文本 Char";
mso-style-priority:99;
mso-style-link:纯文本;
font-family:"Calibri","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><![if mso 9]><style>p.MsoNormal
{margin-left:9.0pt;}
</style><![endif]><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple" style="margin-left:9.0pt;margin-top:9.0pt;margin-right:9.0pt;margin-bottom:9.0pt">
<div class="WordSection1">
<p class="MsoPlainText"><span lang="EN-US">I agree with you that we should limit the disk IO bandwidth in copy_image() to avoid to affect other instance on the same host too much .<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">We found a similar thing in the volume migration.
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Sometimes, it will use "dd" command to migrate volume without any IO/ throughput limitation.
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">We try to use "pv" command to throttle it.
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Detail info in blueprint:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><a href="https://blueprints.launchpad.net/cinder/+spec/throttle-cinder-migrate">https://blueprints.launchpad.net/cinder/+spec/throttle-cinder-migrate</a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Jeremy Liu<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Wangpan [mailto:hzwangpan@corp.netease.com]
<br>
<b>Sent:</b> Monday, February 17, 2014 10:50 AM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> Re: [openstack-dev] [nova] Should we limit the disk IO bandwidth in copy_image while creating new instance?<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="color:black">Hi yunhong,</span><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US">I agree with you of the taking I/O bandwidth as a resource, but it may be not so easy to implement.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US">Your another thinking about the launch time may be not so terrible, only the first boot it will be affected.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif";color:silver">2014-02-17</span><span lang="EN-US"><o:p></o:p></span></p>
<div class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">
<hr size="2" width="122" style="width:91.5pt" align="left">
</span></div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif";color:silver">Wangpan</span><span lang="EN-US"><o:p></o:p></span></p>
<div>
<div class="MsoNormal" align="center" style="margin:0cm;margin-bottom:.0001pt;text-align:center">
<span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">
<hr size="2" width="100%" align="center">
</span></div>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><strong><span style="font-size:10.0pt;font-family:宋体">发件人：</span></strong><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">yunhong jiang <<a href="mailto:yunhong.jiang@linux.intel.com">yunhong.jiang@linux.intel.com</a>></span><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><strong><span style="font-size:10.0pt;font-family:宋体">发送时间：</span></strong><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">2014-02-15 08:21</span><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><strong><span style="font-size:10.0pt;font-family:宋体">主题：</span></strong><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">Re: [openstack-dev] [nova] Should we limit
the disk IO bandwidth in copy_image while creating new instance?</span><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><strong><span style="font-size:10.0pt;font-family:宋体">收件人：</span></strong><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">"OpenStack Development Mailing List (not for
usage questions)"<<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>></span><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><strong><span style="font-size:10.0pt;font-family:宋体">抄送：</span></strong><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">On Fri, 2014-02-14 at 10:22 +0100, Sylvain Bauza wrote: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> Instead of limitating the consumed bandwidth by proposiong a <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> configuration flag (yet another one, and which default value to be <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> set ?), I would propose to only decrease the niceness of the process <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> itself, so that other processes would get first the I/O access. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> That's not perfect I assume, but that's a quick workaround limitating <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> the frustration. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> -Sylvain <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">Decrease goodness is good for a short term, Some small concerns are, <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">will that cause long launch time if the host is I/O intensive? And if <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">launch time is billed also, then not fair for the new instance also. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif""> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">I think the ideal world is I/O QoS like through cgroup, take I/O <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">bandwidth as a resource, and take the copy_image as an consumption of <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">the I/O bandwidth resource. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif""> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">Thanks <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">--jyh <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> 2014-02-14 4:52 GMT+01:00 Wangpan <<a href="mailto:hzwangpan@corp.netease.com">hzwangpan@corp.netease.com</a>>: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> Currently nova doesn't limit the disk IO bandwidth in <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> copy_image() method while creating a new instance, so the <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> other instances on this host may be affected by this high disk <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> IO consuming operation, and some time-sensitive business(e.g <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> RDS instance with heartbeat) may be switched between master <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> and slave. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> So can we use the `rsync --bwlimit=${bandwidth} src dst` <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> command instead of `cp src dst` while copy_image in <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> create_image() of libvirt driver, the remote image copy <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> operation also can be limited by `rsync --bwlimit= <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> ${bandwidth}` or `scp -l=${bandwidth}`, this parameter <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> ${bandwidth} can be a new configuration in nova.conf which <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> allow cloud admin to config it, it's default value is 0 which <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> means no limitation, then the instances on this host will be <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> not affected while a new instance with not cached image is <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> creating. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> the example codes: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> nova/virt/libvit/utils.py: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> diff --git a/nova/virt/libvirt/utils.py <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> b/nova/virt/libvirt/utils.py <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> index e926d3d..5d7c935 100644 <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> --- a/nova/virt/libvirt/utils.py <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> +++ b/nova/virt/libvirt/utils.py <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> @@ -473,7 +473,10 @@ def copy_image(src, dest, host=None): <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> # sparse files. I.E. holes will not be written to <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> DEST, <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> # rather recreated efficiently. In addition, since <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> # coreutils 8.11, holes can be read efficiently too. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> - execute('cp', src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + if CONF.mbps_in_copy_image > 0: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + execute('rsync', '--bwlimit=%s' % <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> CONF.mbps_in_copy_image * 1024, src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + else: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + execute('cp', src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> else: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> dest = "%s:%s" % (host, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> # Try rsync first as that can compress and create <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> sparse dest files. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> @@ -484,11 +487,22 @@ def copy_image(src, dest, host=None): <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> # Do a relatively light weight test first, so <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> that we <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> # can fall back to scp, without having run out of <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> space <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> # on the destination for example. <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> - execute('rsync', '--sparse', '--compress', <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> '--dry-run', src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + if CONF.mbps_in_copy_image > 0: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + execute('rsync', '--sparse', '--compress', <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> '--dry-run', <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + '--bwlimit=%s' % <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> CONF.mbps_in_copy_image * 1024, src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + else: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + execute('rsync', '--sparse', '--compress', <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> '--dry-run', src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> except processutils.ProcessExecutionError: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> - execute('scp', src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + if CONF.mbps_in_copy_image > 0: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + execute('scp', '-l', '%s' % <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> CONF.mbps_in_copy_image * 1024 * 8, src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + else: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + execute('scp', src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> else: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> - execute('rsync', '--sparse', '--compress', src, <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + if CONF.mbps_in_copy_image > 0: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + execute('rsync', '--sparse', '--compress', <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + '--bwlimit=%s' % <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> CONF.mbps_in_copy_image * 1024, src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + else: <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> + execute('rsync', '--sparse', '--compress', <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> src, dest) <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> 2014-02-14 <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> ______________________________________________________________ <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> Wangpan <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> _______________________________________________ <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> OpenStack-dev mailing list <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> _______________________________________________ <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> OpenStack-dev mailing list <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif""> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif""> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif""> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif""> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">_______________________________________________ <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif"">OpenStack-dev mailing list <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif""><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><span lang="EN-US" style="font-size:10.0pt;font-family:"Verdana","sans-serif""><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a> <o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>