<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Feb 18, 2014 at 11:52 PM, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
All this blind meatgrinder behavior was putting tons of code into the<br>
gate that could not pass. That, coupled with other race conditions we<br>
were dealing with, put us into a state where we had a 60hr gate queue.<br>
<br>
So we're trying out a new system. A change will not move into the gate<br>
unless there is both a +A and Jenkins +1 on the patch.<br>
<br>
We also rerun check results on comment if the test results are > 72hrs<br>
old, so there is always a reasonably fresh version of the results. This<br>
also helps detect merge conflicts early.<br>
<br></blockquote><div><br></div><div>Thanks for the update Sean. I think the check re-run currently gets done even if the new comment is a -2. Perhaps we could skip<br>it in that case?<br></div><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also when you +A a patch, if there aren't 24hr fresh test results, we<br>
rerun check first, then if that passes, it gets sent to the gate.<br>
<br>
There is still a bit of a sticky part of the flow if it fails in the<br>
gate. Because that means you don't satisfy the +1 jenkins requirement.<br>
Still trying to get the right flow worked out there.<br>
<br>
-Sean<br>
<div class=""><br>
On 02/18/2014 07:51 AM, Sergey Lukjanov wrote:<br>
> You already can reverify on any approved change. Jenkins automatically<br>
> runs check pipeline jobs after 3 days.<br>
><br>
><br>
> On Tue, Feb 18, 2014 at 4:29 PM, Christopher Yeoh <<a href="mailto:cbkyeoh@gmail.com">cbkyeoh@gmail.com</a><br>
</div><div class="">> <mailto:<a href="mailto:cbkyeoh@gmail.com">cbkyeoh@gmail.com</a>>> wrote:<br>
><br>
> On Tue, Feb 18, 2014 at 12:27 AM, Gary Kotton <<a href="mailto:gkotton@vmware.com">gkotton@vmware.com</a><br>
</div><div class="">> <mailto:<a href="mailto:gkotton@vmware.com">gkotton@vmware.com</a>>> wrote:<br>
><br>
> Thanks!<br>
> That makes sense. Just odd how a -1 was received.<br>
><br>
><br>
> So I think that now a "check" run is automatically done if the<br>
> latest Jenkins run is too old (7 days?)<br>
> This is done because gate failures are so costly. The check run<br>
> failing would return -1 instead of a<br>
> gate failure of -2.<br>
><br>
><br>
><br>
><br>
> On 2/17/14 3:15 PM, "Akihiro Motoki" <<a href="mailto:motoki@da.jp.nec.com">motoki@da.jp.nec.com</a><br>
</div><div><div class="h5">> <mailto:<a href="mailto:motoki@da.jp.nec.com">motoki@da.jp.nec.com</a>>> wrote:<br>
><br>
> >Hi Gary,<br>
> ><br>
> >According to zuul layout.yaml [1], "reverify bug #" should<br>
> still work<br>
> >but it seems to work only when verified score from jenkins is -2.<br>
> ><a href="https://urldefense.proofpoint.com/v1/url?u=https://github.com/openstack-in" target="_blank">https://urldefense.proofpoint.com/v1/url?u=https://github.com/openstack-in</a><br>
> >fra/config/blob/master/modules/openstack_project/files/zuul/layout.yaml%23<br>
> >L25&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg4<br>
> >5MkPhCZFxPEq8%3D%0A&m=Nf6%2FyHMSSchQO59xIcg6NKX1O2wlkkHHd42bYQim0k0%3D%0A&<br>
> >s=8fc4d7e6970936977dc85989e4e7e9429afb15f5091a768efa4ce236417d9c9b<br>
> ><br>
> >Note that core team can trigger gate jobs by re-approving the<br>
> patch.<br>
> ><br>
> >Thanks,<br>
> >Akihiro<br>
> ><br>
> >(2014/02/17 22:03), Gary Kotton wrote:<br>
> >> Hi,<br>
> >> The "reverify no bug" was removed. But "reverify bug #" used<br>
> to work.<br>
> >>That no longer does. With the constant gate failures how can<br>
> we ensure<br>
> >>that a approved patch does a retry?<br>
> >> Thanks<br>
> >> Gary<br>
> >><br>
> >> From: Sylvain Bauza <<a href="mailto:sylvain.bauza@gmail.com">sylvain.bauza@gmail.com</a><br>
> <mailto:<a href="mailto:sylvain.bauza@gmail.com">sylvain.bauza@gmail.com</a>><br>
</div></div>> >><mailto:<a href="mailto:sylvain.bauza@gmail.com">sylvain.bauza@gmail.com</a> <mailto:<a href="mailto:sylvain.bauza@gmail.com">sylvain.bauza@gmail.com</a>>>><br>
<div class="">> >> Reply-To: "OpenStack Development Mailing List (not for usage<br>
> >>questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a><br>
> <mailto:<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
</div>> >><mailto:<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a><br>
<div class="">> <mailto:<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>>>><br>
> >> Date: Monday, February 17, 2014 2:53 PM<br>
> >> To: "OpenStack Development Mailing List (not for usage<br>
> questions)"<br>
> >><<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a><br>
> <mailto:<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
</div>> >><mailto:<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a><br>
<div class="">> <mailto:<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>>>><br>
> >> Subject: Re: [openstack-dev] [infra] reverify/recheck<br>
> >><br>
> >> Hi Gary,<br>
> >><br>
> >> That's normal, this command has been removed since Dec'13, see<br>
> >><a href="https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/pip" target="_blank">https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/pip</a><br>
> >>ermail/openstack-dev/2013-December/021649.html&k=oIvRg1%2BdGAgOoM1BIlLLqw<br>
> >>%3D%3D%0A&r=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=Nf6%2Fy<br>
> >>HMSSchQO59xIcg6NKX1O2wlkkHHd42bYQim0k0%3D%0A&s=826274ca8ad9562b557322274a<br>
> >>cdacd97482338456820af8c330b76ea7639838<br>
> >><br>
> >><<a href="https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/pi" target="_blank">https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/pi</a><br>
> >>permail/openstack-dev/2013-December/021649.html&k=oIvRg1%2BdGAgOoM1BIlLLq<br>
> >>w%3D%3D%0A&r=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=B8yQ75<br>
> >>uRFa7dyD%2FbgPgO%2FMT2x229MkK1vHWBVAzpFtM%3D%0A&s=d9cbcbde99b7c88c15ca138<br>
> >>499de8f36edd4247ce351e41b241d675b09b79956><br>
> >><br>
> >> -Sylvain<br>
> >><br>
> >><br>
> >> 2014-02-17 13:00 GMT+01:00 Gary Kotton <<a href="mailto:gkotton@vmware.com">gkotton@vmware.com</a><br>
> <mailto:<a href="mailto:gkotton@vmware.com">gkotton@vmware.com</a>><br>
</div>> >><mailto:<a href="mailto:gkotton@vmware.com">gkotton@vmware.com</a> <mailto:<a href="mailto:gkotton@vmware.com">gkotton@vmware.com</a>>>>:<br>
<div class="">> >><br>
> >> Hi,<br>
> >> It seems that the command 'reverify bug <number>' is not<br>
> working.<br>
> >>Anyone else experienced this lately.<br>
> >> Thanks<br>
> >> Gary<br>
> >><br>
> >> _______________________________________________<br>
> >> OpenStack-dev mailing list<br>
> >> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <mailto:<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>><br>
</div>> >><mailto:<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<div class="">> <mailto:<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>>><br>
> >><br>
> >><a href="https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/cgi" target="_blank">https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/cgi</a><br>
> >>-bin/mailman/listinfo/openstack-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r<br>
> >>=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=Nf6%2FyHMSSchQO59x<br>
> >>Icg6NKX1O2wlkkHHd42bYQim0k0%3D%0A&s=1a2a59024e18b786b5c2c13535b7f3d050363<br>
> >>ff628dc96b8561e12489d30c0bd<br>
> >><br>
> >><<a href="https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/cg" target="_blank">https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/cg</a><br>
> >>i-bin/mailman/listinfo/openstack-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&<br>
> >>r=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=B8yQ75uRFa7dyD%2F<br>
> >>bgPgO%2FMT2x229MkK1vHWBVAzpFtM%3D%0A&s=21e7f4ebc24f0a13780981720f9332111d<br>
> >>d603f3c0661229dc90d82bfb5c3122><br>
> >><br>
> >><br>
> >><br>
> >><br>
> >> _______________________________________________<br>
> >> OpenStack-dev mailing list<br>
> >> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <mailto:<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>><br>
> >><br>
> >><a href="https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/cgi" target="_blank">https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/cgi</a><br>
> >>-bin/mailman/listinfo/openstack-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r<br>
> >>=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=Nf6%2FyHMSSchQO59x<br>
> >>Icg6NKX1O2wlkkHHd42bYQim0k0%3D%0A&s=1a2a59024e18b786b5c2c13535b7f3d050363<br>
> >>ff628dc96b8561e12489d30c0bd<br>
> >><br>
> >_______________________________________________<br>
> >OpenStack-dev mailing list<br>
> ><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <mailto:<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>><br>
</div><div class="">> ><a href="https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/cgi-" target="_blank">https://urldefense.proofpoint.com/v1/url?u=http://lists.openstack.org/cgi-</a><br>
> >bin/mailman/listinfo/openstack-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=e<br>
> >H0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=Nf6%2FyHMSSchQO59xIcg<br>
> >6NKX1O2wlkkHHd42bYQim0k0%3D%0A&s=1a2a59024e18b786b5c2c13535b7f3d050363ff62<br>
> >8dc96b8561e12489d30c0bd<br>
><br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
</div>> <mailto:<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>><br>
<div class="">> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
</div>> <mailto:<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>><br>
<div class="HOEnZb"><div class="h5">> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Sincerely yours,<br>
> Sergey Lukjanov<br>
> Savanna Technical Lead<br>
> Mirantis Inc.<br>
><br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
<br>
--<br>
</div></div><span class="HOEnZb"><font color="#888888">Sean Dague<br>
Samsung Research America<br>
<a href="mailto:sean@dague.net">sean@dague.net</a> / <a href="mailto:sean.dague@samsung.com">sean.dague@samsung.com</a><br>
<a href="http://dague.net" target="_blank">http://dague.net</a><br>
<br>
</font></span><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>