<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body style='font-family: Verdana,Geneva,sans-serif'>
<p>On 2014-02-18 09:15, Christopher Armstrong wrote:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px">
<div dir="ltr">This change was recently merged:
<div> </div>
<div><a href="https://review.openstack.org/#/c/69133/">https://review.openstack.org/#/c/69133/</a></div>
<div> </div>
<div>Unfortunately it didn't enable lazy translations for the unit tests, so it didn't catch the many places in Heat that won't work when lazy translations are enabled. Notably there are a lot of cases where the code adds the result of a call to _() with another string, and Message objects (which are returned from _ when lazy translations are enabled) can't be added, resulting in an exception being raised.</div>
<div> </div>
<div>I think the best course of action would be to revert this change, and then reintroduce it along with patches to fix all the problems, while enabling it for the unit tests so bugs won't be reintroduced in the future.</div>
<div> </div>
</div>
</blockquote>
<div dir="ltr">
<div>Agreed. That behavior was intentional because we shouldn't be adding translated strings that way, but obviously it needs to be fixed before lazy translation is enabled. :-)</div>
</div>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px">
<div dir="ltr">
<div> </div>
<div>Interestingly it also didn't fail any of the tempest tests, I'm not sure why.</div>
<div> </div>
</div>
</blockquote>
<div dir="ltr">
<div>That is kind of concerning. I see that the error does show up in the logs a couple of times though: http://logs.openstack.org/33/69133/5/gate/gate-tempest-dsvm-full/d6aa1bd/logs/screen-h-api.txt.gz#_2014-02-17_17_38_25_521</div>
<div> </div>
<div>Maybe this is something that would need the new error message test enabled to be caught?</div>
</div>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px">
<div dir="ltr">
<div>
<div> </div>
-- <br />
<div dir="ltr">
<div>IRC: radix</div>
Christopher Armstrong</div>
</div>
</div>
<br />
<pre>_______________________________________________
OpenStack-dev mailing list
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></pre>
</blockquote>
<p> </p>
<div> </div>
</body></html>