<font size=2 face="sans-serif">All,</font>
<br>
<br><font size=2 face="sans-serif">Myself and Jim Carey have been working
on getting the right solution for making lazy_translation work through
Nova and Cinder. <br>
</font>
<br><font size=2 face="sans-serif">The patch should have also had changes
to remove the use of str() in any LOG or exception messages as well as
the removal of any places where strings were being '+' ed together. In
the case of Cinder we are doing it as two separate patches that are dependent.
I am surprised that this change got past Jenkins. In the case
of Cinder and Nova unit test caught a number of problems.</font>
<br>
<br><font size=2 face="sans-serif">We will make sure to work with Liang
Chen to avoid this happening again.</font><a href=https://review.openstack.org/#/dashboard/7135></a>
<br><font size=3><b><i><br>
Jay S. Bryant</i></b><br>
<i>IBM Cinder Subject Matter Expert
& Cinder Core Member</i><br>
Department 7YLA, Building 015-2, Office E125, Rochester, MN<br>
Telephone: (507) 253-4270, FAX (507) 253-6410<br>
TIE Line: 553-4270<br>
E-Mail: jsbryant@us.ibm.com<br>
--------------------------------------------------------------------<br>
All the world's a stage and most of us are desperately unrehearsed.<br>
-- Sean
O'Casey<br>
--------------------------------------------------------------------</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Ben Nemec <openstack@nemebean.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">openstack-dev@lists.openstack.org,
</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">02/18/2014 10:37 AM</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [openstack-dev]
[Heat] lazy translation is breaking Heat</font>
<br>
<hr noshade>
<br>
<br>
<br><font size=3 face="Verdana">On 2014-02-18 09:15, Christopher Armstrong
wrote:</font>
<p><font size=3 face="Verdana">This change was recently merged: </font>
<br><font size=3 face="Verdana"> </font>
<br><a href=https://review.openstack.org/#/c/69133/><font size=3 color=blue face="Verdana"><u>https://review.openstack.org/#/c/69133/</u></font></a>
<br><font size=3 face="Verdana"> </font>
<br><font size=3 face="Verdana">Unfortunately it didn't enable lazy translations
for the unit tests, so it didn't catch the many places in Heat that won't
work when lazy translations are enabled. Notably there are a lot of cases
where the code adds the result of a call to _() with another string, and
Message objects (which are returned from _ when lazy translations are enabled)
can't be added, resulting in an exception being raised.</font>
<br><font size=3 face="Verdana"> </font>
<br><font size=3 face="Verdana">I think the best course of action would
be to revert this change, and then reintroduce it along with patches to
fix all the problems, while enabling it for the unit tests so bugs won't
be reintroduced in the future.</font>
<br><font size=3 face="Verdana"> </font>
<br><font size=3 face="Verdana">Agreed. That behavior was intentional
because we shouldn't be adding translated strings that way, but obviously
it needs to be fixed before lazy translation is enabled. :-)</font>
<br><font size=3 face="Verdana"> </font>
<br><font size=3 face="Verdana">Interestingly it also didn't fail any of
the tempest tests, I'm not sure why.</font>
<br><font size=3 face="Verdana"> </font>
<br><font size=3 face="Verdana">That is kind of concerning. I see
that the error does show up in the logs a couple of times though: </font><a href="http://logs.openstack.org/33/69133/5/gate/gate-tempest-dsvm-full/d6aa1bd/logs/screen-h-api.txt.gz#_2014-02-17_17_38_25_521"><font size=3 face="Verdana">http://logs.openstack.org/33/69133/5/gate/gate-tempest-dsvm-full/d6aa1bd/logs/screen-h-api.txt.gz#_2014-02-17_17_38_25_521</font></a>
<br><font size=3 face="Verdana"> </font>
<br><font size=3 face="Verdana">Maybe this is something that would need
the new error message test enabled to be caught?</font>
<br><font size=3 face="Verdana"> </font>
<br><font size=3 face="Verdana">-- </font>
<br><font size=3 face="Verdana">IRC: radix</font>
<br><font size=3 face="Verdana">Christopher Armstrong</font>
<br>
<br><font size=3 face="Verdana">_______________________________________________<br>
OpenStack-dev mailing list<br>
</font><a href="mailto:OpenStack-dev@lists.openstack.org"><font size=3 color=blue face="Verdana"><u>OpenStack-dev@lists.openstack.org</u></font></a><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev"><font size=3 color=blue face="Verdana"><u>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</u></font></a>
<p><font size=3 face="Verdana"> </font>
<p><font size=3 face="Verdana"> </font><tt><font size=2>_______________________________________________<br>
OpenStack-dev mailing list<br>
OpenStack-dev@lists.openstack.org<br>
</font></tt><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev"><tt><font size=2>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</font></tt></a><tt><font size=2><br>
</font></tt>
<p>