<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jan 27, 2014, at 6:57 PM, Christopher Yeoh <<a href="mailto:cbkyeoh@gmail.com">cbkyeoh@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jan 28, 2014 at 12:55 AM, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 01/27/2014 09:07 AM, Macdonald-Wallace, Matthew wrote:<br>
> Hi Sean,<br>
><br>
> I'm currently working on moving away from the "built-in" logging to use log_config=<filename> and the python logging framework so that we can start shipping to logstash/sentry/<insert other useful tool here>.<br>
><br>
> I'd be very interested in getting involved in this, especially from a "why do we have log messages that are split across multiple lines" perspective!<br>
<br>
</div>Do we have many that aren't either DEBUG or TRACE? I thought we were<br>
pretty clean there.<br>
<div class="im"><br>
> Cheers,<br>
><br>
> Matt<br>
><br>
> P.S. FWIW, I'd also welcome details on what the "Audit" level gives us that the others don't... :)<br>
<br>
</div>Well as far as I can tell the AUDIT level was a prior drive by<br>
contribution that's not being actively maintained. Honestly, I think we<br>
should probably rip it out, because I don't see any in tree tooling to<br>
use it, and it's horribly inconsistent.<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div><br></div><div>For the uses I've seen of it in the nova api code INFO would be perfectly fine in place of AUDIT.<br></div></div></div></div></blockquote><div><br></div>+1 AUDIT was added for a specific NASA use case because we needed a clean feed of important actions for security compliance and many upstream libraries were putting out INFO logs that we did not want included. Safe to rip it out IMO.</div><div><br></div><div>Vish</div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>I'd be happy to help out with patches to cleanup the logging in n-api.<br>
<br></div><div>One other thing to look at - I've noticed with logs is that when something like glanceclient code (just as an example) is called from nova,<br></div><div>we can get ERROR level messages for say image not found when its actually perfectly expected that this will occur.<br>
I'm not sure if we should be changing the error level in glanceclient or just forcing any error logging in glanceclient when<br>called from Nova to a lower level though.<br></div><div><br></div><div>Chris<br></div></div>
</div></div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote></div><br></body></html>