<html><body>
<p><font size="2" face="sans-serif">Hi David,</font><br>
<br>
<font size="2" face="sans-serif">Just had a short talk with markwash. Based on the new design of v2, we don't need 'killed' status anymore. Since when user is uploading a modification to an image and the upload fails, it should just go back to what it was, it shouldn't be deactivated.</font><br>
<br>
<font size="2" face="sans-serif">Thanks & Best regards,<br>
Fei Long Wang (Íõ·ÉÁú)<br>
---------------------------------------------------------------------<br>
Tech Lead of Nitrogen (SME team)<br>
Cloud Solutions and OpenStack Development<br>
Tel: 8610-82450513 | T/L: 905-0513 <br>
Email: flwang@cn.ibm.com<br>
China Systems & Technology Laboratory in Beijing<br>
---------------------------------------------------------------------<br>
</font><br>
<br>
<img width="16" height="16" src="cid:1__=C7BBF6FFDFDC41AA8f9e8a93df938@cn.ibm.com" border="0" alt="Inactive hide details for David Koo ---01/26/2014 09:13:09 PM---Hi Fei, Thanks for the confirmation."><font size="2" color="#424282" face="sans-serif">David Koo ---01/26/2014 09:13:09 PM---Hi Fei, Thanks for the confirmation.</font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">David Koo <kpublicmail@gmail.com></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">OpenStack Development Mailing List <openstack-dev@lists.openstack.org>, </font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">01/26/2014 09:13 PM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">Re: [openstack-dev] Fw: [Glance] Is the 'killed' state ever set in v2?</font><br>
<hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br>
<br>
<br>
<tt><font size="2"><br>
Hi Fei,<br>
<br>
Thanks for the confirmation.<br>
<br>
> I think you're right. The 'killed' status should be set in method upload()<br>
> if there is an upload failure, see<br>
> </font></tt><tt><font size="2"><a href="https://github.com/openstack/glance/blob/master/glance/common/utils.py#L244">https://github.com/openstack/glance/blob/master/glance/common/utils.py#L244</a></font></tt><tt><font size="2"><br>
<br>
I think you meant:<br>
<br>
</font></tt><tt><font size="2"><a href="https://github.com/openstack/glance/blob/master/glance/api/v1/upload_utils.py#L244">https://github.com/openstack/glance/blob/master/glance/api/v1/upload_utils.py#L244</a></font></tt><tt><font size="2"><br>
<br>
(the safe_kill() call) right?<br>
<br>
--<br>
Koo<br>
<br>
<br>
> ------------------ Original ------------------<br>
> From: "David Koo"<kpublicmail@gmail.com>;<br>
> Date: Jan 26, 2014<br>
> To: "OpenStack Development Mailing<br>
> List"<openstack-dev@lists.openstack.org>;<br>
> Subject: [openstack-dev] [Glance] Is the 'killed' state ever set in v2?<br>
> <br>
> Hi All,<br>
> <br>
> While trying to work on a bug I was trying to simulate some image<br>
> download failures and found that apparently the 'killed' state is never<br>
> set using v2 APIs.<br>
> <br>
> If I understand correctly, a file upload goes to<br>
> api.v2.image_data.ImageDataController.upload and goes all the way to<br>
> store.ImageProxy.set_data which proceeds to write to the backend store.<br>
> <br>
> If the backend store raises an exception it is simply propagated all the<br>
> way up. The notifier re-encodes the exceptions (which is the bug I was<br>
> looking at) but doesn't do anything about the image status.<br>
> <br>
> Nowhere does the image status seem to get set to 'killed'.<br>
> <br>
> Before I log a bug I just wanted to confirm with everybody whether or<br>
> not I've missed out on something.<br>
> <br>
> Thanks.<br>
> <br>
> --<br>
> Koo<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
OpenStack-dev@lists.openstack.org<br>
</font></tt><tt><font size="2"><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></font></tt><tt><font size="2"><br>
<br>
</font></tt><br>
</body></html>