<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hello Lingxian,<br>
<br>
Actually I'm planning to remove both of them.<br>
<br>
I'm working on integration of argcomplete
(<a class="moz-txt-link-freetext" href="https://github.com/kislyuk/argcomplete">https://github.com/kislyuk/argcomplete</a>) library to openstack
clients:<br>
<a class="moz-txt-link-freetext" href="https://review.openstack.org/#/c/65863/">https://review.openstack.org/#/c/65863/</a><br>
<a class="moz-txt-link-freetext" href="https://review.openstack.org/#/c/65864/">https://review.openstack.org/#/c/65864/</a><br>
<a class="moz-txt-link-freetext" href="https://review.openstack.org/#/c/65865/">https://review.openstack.org/#/c/65865/</a><br>
<br>
With such approach we'll remove both commands and simplify
competition implementation.<br>
<br>
Regards,<br>
Alexei Kornienko<br>
<br>
On 01/15/2014 08:51 AM, Lingxian Kong wrote:<br>
</div>
<blockquote
cite="mid:CALjNAZ1SP_ewq3jw7pnwfxq3CWkoKX39Hw8kfFMFfPqMpQtLuQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_default">
<div class="gmail_default"><font face="verdana, sans-serif">Now,
novaclient supports 'bash-completion' and
'bash_completion' commands at the same time, after I
checked the commit history, I found that the
'_add_bash_completion_subparser' function and
'do_bash_completion' function were added in at 2011/12/16
by Rick Harris, with the Change-Id:
If882f7a822ef6b1e58666b3af6f7166ab0a230fe.</font></div>
<div class="gmail_default"><font face="verdana, sans-serif"><br>
</font></div>
<div class="gmail_default"><font face="verdana, sans-serif">then,
there are two parsers with the same usage, but with
different commands, one is 'bash-completion', and the
other is 'bash_completion', I think it's not what the
author supposed to do.</font></div>
<div class="gmail_default"><font face="verdana, sans-serif"><br>
</font></div>
<div class="gmail_default"><font face="verdana, sans-serif">and
by the way, there are two things should be noticed:</font></div>
<div class="gmail_default">
<font face="verdana, sans-serif">1. there is only unittest
for 'bash-completion'.</font></div>
<div class="gmail_default"><font face="verdana, sans-serif">2.
the command 'bash_completion' can't be found with 'nova
help', which means it's not seen by users.</font></div>
<div class="gmail_default"><font face="verdana, sans-serif"><br>
</font></div>
<div class="gmail_default"><font face="verdana, sans-serif">so,
I purpose removing 'bash_completion'. Thoughts?</font></div>
</div>
<div><br>
</div>
-- <br>
<div dir="ltr">
<div><b><font style="background-color:rgb(243,243,243)"
color="#000000" face="courier new, monospace">---------------------------------------</font></b></div>
<div><font color="#0000ff" face="comic sans ms, sans-serif"><b>Lingxian
Kong</b></font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">Huawei
Technologies Co.,LTD.</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">IT
Product Line CloudOS PDU</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">China,
Xi'an</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">Mobile:
+86-18602962792</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">Email:
<a moz-do-not-send="true"
href="mailto:konglingxian@huawei.com" target="_blank">konglingxian@huawei.com</a>;
<a moz-do-not-send="true"
href="mailto:anlin.kong@gmail.com" target="_blank">anlin.kong@gmail.com</a></font></div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
OpenStack-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>
<a class="moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>