<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">Hi Alexei:</div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif">
Thanks for your information. IMO, if you remove them, the file tools/nova.bash_completion should be removed too, right?</div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif">
If so, I'm willing to participate with you to do this.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014/1/15 Alexei Kornienko <span dir="ltr"><<a href="mailto:alexei.kornienko@gmail.com" target="_blank">alexei.kornienko@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>Hello Lingxian,<br>
<br>
Actually I'm planning to remove both of them.<br>
<br>
I'm working on integration of argcomplete
(<a href="https://github.com/kislyuk/argcomplete" target="_blank">https://github.com/kislyuk/argcomplete</a>) library to openstack
clients:<br>
<a href="https://review.openstack.org/#/c/65863/" target="_blank">https://review.openstack.org/#/c/65863/</a><br>
<a href="https://review.openstack.org/#/c/65864/" target="_blank">https://review.openstack.org/#/c/65864/</a><br>
<a href="https://review.openstack.org/#/c/65865/" target="_blank">https://review.openstack.org/#/c/65865/</a><br>
<br>
With such approach we'll remove both commands and simplify
competition implementation.<br>
<br>
Regards,<br>
Alexei Kornienko<div><div class="h5"><br>
<br>
On 01/15/2014 08:51 AM, Lingxian Kong wrote:<br>
</div></div></div>
<blockquote type="cite"><div><div class="h5">
<div dir="ltr">
<div class="gmail_default">
<div class="gmail_default"><font face="verdana, sans-serif">Now,
novaclient supports 'bash-completion' and
'bash_completion' commands at the same time, after I
checked the commit history, I found that the
'_add_bash_completion_subparser' function and
'do_bash_completion' function were added in at 2011/12/16
by Rick Harris, with the Change-Id:
If882f7a822ef6b1e58666b3af6f7166ab0a230fe.</font></div>
<div class="gmail_default"><font face="verdana, sans-serif"><br>
</font></div>
<div class="gmail_default"><font face="verdana, sans-serif">then,
there are two parsers with the same usage, but with
different commands, one is 'bash-completion', and the
other is 'bash_completion', I think it's not what the
author supposed to do.</font></div>
<div class="gmail_default"><font face="verdana, sans-serif"><br>
</font></div>
<div class="gmail_default"><font face="verdana, sans-serif">and
by the way, there are two things should be noticed:</font></div>
<div class="gmail_default">
<font face="verdana, sans-serif">1. there is only unittest
for 'bash-completion'.</font></div>
<div class="gmail_default"><font face="verdana, sans-serif">2.
the command 'bash_completion' can't be found with 'nova
help', which means it's not seen by users.</font></div>
<div class="gmail_default"><font face="verdana, sans-serif"><br>
</font></div>
<div class="gmail_default"><font face="verdana, sans-serif">so,
I purpose removing 'bash_completion'. Thoughts?</font></div>
</div>
<div><br>
</div>
-- <br>
<div dir="ltr">
<div><b><font style="background-color:rgb(243,243,243)" color="#000000" face="courier new, monospace">---------------------------------------</font></b></div>
<div><font color="#0000ff" face="comic sans ms, sans-serif"><b>Lingxian
Kong</b></font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">Huawei
Technologies Co.,LTD.</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">IT
Product Line CloudOS PDU</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">China,
Xi'an</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">Mobile:
+86-18602962792</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">Email:
<a href="mailto:konglingxian@huawei.com" target="_blank">konglingxian@huawei.com</a>;
<a href="mailto:anlin.kong@gmail.com" target="_blank">anlin.kong@gmail.com</a></font></div>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>_______________________________________________
OpenStack-dev mailing list
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</blockquote>
<br>
</div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div><b><font color="#000000" style="background-color:rgb(243,243,243)" face="courier new, monospace">---------------------------------------</font></b></div>
<div><font color="#0000ff" face="comic sans ms, sans-serif"><b>Lingxian Kong</b></font></div><div><font color="#ff00ff" face="comic sans ms, sans-serif">Huawei Technologies Co.,LTD.</font></div><div><font color="#ff00ff" face="comic sans ms, sans-serif">IT Product Line CloudOS PDU</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">China, Xi'an</font></div><div><font color="#ff00ff" face="comic sans ms, sans-serif">Mobile: +86-18602962792</font></div><div><font color="#ff00ff" face="comic sans ms, sans-serif">Email: <a href="mailto:konglingxian@huawei.com" target="_blank">konglingxian@huawei.com</a>; <a href="mailto:anlin.kong@gmail.com" target="_blank">anlin.kong@gmail.com</a></font></div>
</div>
</div>