<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jan 15, 2014, at 6:40 AM, Doug Hellmann <<a href="mailto:doug.hellmann@dreamhost.com">doug.hellmann@dreamhost.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jan 15, 2014 at 6:51 AM, Victor Sergeyev <span dir="ltr"><<a href="mailto:vsergeyev@mirantis.com" target="_blank">vsergeyev@mirantis.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hello All.</div><div><br></div><div>As for lockutils - a few days ago I wondered why we used custom oslo module instead of lockfile library [1]. AFAIK, it must be due to this bug [2] (please fix me, if I wrong).</div>
<div><br></div><div>This library is available on github [3] and there is a pull-request fixing the bug [4], but unfortunately it hasn’t been merged yet. And seems that this project is not maintained anymore - author told, that he “haven't done anything with it in a few years” [5]. </div>
<div><br></div><div>So my question is - can we start maintaining this library (put it on stackforge) and use it instead of oslo.lockutils? Or maybe we could include parts of oslo.lockutils into lockfile? Or vice versa, incorporate lockfile into oslo.lockutils?</div>
</div></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">That might make sense.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">
It looks like the lockfile package on PyPI is meant to be portable to Windows, and I'm not sure if we care about that. Does it provide any other useful features or API improvements over the lockfiles module we have? We'll still need a wrapper, since we have configuration options in our module now.</div>
<div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">How much work would it be to transition to the other library?</div></div><div class="gmail_default" style="font-size:small">
<br></div><div class="gmail_default" style="font-size:small">Doug</div></div></div></div></blockquote><div><br></div>We used lockfile in the early days of openstack:</div><div><br></div><div><a href="https://github.com/openstack/nova/blob/essex-rc2/nova/utils.py#L957">https://github.com/openstack/nova/blob/essex-rc2/nova/utils.py#L957</a></div><div><br></div><div>and it was plagued with many problems. Switching to fsync based locks solved a lot of these</div><div>issues.</div><div><br></div><div>Vish</div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">
<div><br></div><div>[1] <a href="https://pypi.python.org/pypi/lockfile" target="_blank">https://pypi.python.org/pypi/lockfile</a></div><div>[2] <a href="http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632857" target="_blank">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632857</a></div>
<div>[3] <a href="https://github.com/smontanaro/pylockfile" target="_blank">https://github.com/smontanaro/pylockfile</a></div><div>[4] <a href="https://github.com/smontanaro/pylockfile/pull/3" target="_blank">https://github.com/smontanaro/pylockfile/pull/3</a></div>
<div>[5] <a href="https://github.com/smontanaro/pylockfile/pull/3#issuecomment-32085554" target="_blank">https://github.com/smontanaro/pylockfile/pull/3#issuecomment-32085554</a></div></div><div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Jan 15, 2014 at 1:00 AM, Michael Still <span dir="ltr"><<a href="mailto:mikal@stillhq.com" target="_blank">mikal@stillhq.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On Wed, Jan 15, 2014 at 9:27 AM, Ben Nemec <<a href="mailto:openstack@nemebean.com" target="_blank">openstack@nemebean.com</a>> wrote:<br>
<br>
> It would be nice to get lockutils graduated to solve some of the issues<br>
> mentioned in the oslo.db section, but I believe we do have an outstanding<br>
> question regarding its behavior without lock_path being set. I think Clint<br>
> was on board with Sean's proposed solution after quite a bit of discussion<br>
> (<a href="http://lists.openstack.org/pipermail/openstack-dev/2013-December/021620.html" target="_blank">http://lists.openstack.org/pipermail/openstack-dev/2013-December/021620.html</a>),<br>
> so it's possible we could just restore that patch and call it done, but it<br>
> should probably be addressed somehow before graduation.<br>
<br>
</div>I committed a while ago (at the last summit IIRC) to working on<br>
getting lockutils released as a library, but I haven't managed to get<br>
that done yet. If it is blocking other people I can prioritise that<br>
work to being higher on my todo list.<br>
<br>
Part of the problem here is that its my first oslo graduation, so I<br>
need to figure out what to do...<br>
<div><br>
Michael<br>
<br>
--<br>
Rackspace Australia<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote></div><br></body></html>