<div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 13, 2014 at 5:43 PM, Luis A. Garcia <span dir="ltr"><<a href="mailto:luis@linux.vnet.ibm.com" target="_blank">luis@linux.vnet.ibm.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 1/13/2014 1:47 PM, Doug Hellmann wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
There's a review in Oslo to provide a configuration option to turn on<br>
the ability to log in a second language by specifying the locale<br>
(<a href="https://review.openstack.org/#/c/62508/" target="_blank">https://review.openstack.org/<u></u>#/c/62508/</a>).<br>
<br>
Given the recent discussion of adding more configuration options, I<br>
wanted to see what people thought about providing this feature only to<br>
deployers using the external logging configuration file, instead of<br>
oslo.config.<br>
<br>
My idea is to provide a sample config file, so that a deployer would<br>
only have to fill in their locale, and then use the existing option to<br>
specify that logging configuration file to override the built-in logging<br>
behavior.<br>
<br>
What do you think?<br>
<br>
</blockquote>
<br></div></div>
Currently most log configuration options can be done from the corresponding project.conf files [1] in addition to the logging.conf file. In fact I think the project.conf might be a super set of logging features, because there are some log config options that I would not know how to do from the logging.conf file, e.g. instance_uuid_format.<br>
</blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">All of the general purpose logging configuration can be accomplished via the logging.conf file. The format options for instance and instance uuid control the ContextAdapter, and I'm not sure if those can be specified in logging.conf or not.</div>
<div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">I agree that we should ensure logging.conf can be used to configure everything, and we can work on that during the next cycle.</div>
</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I think the reason for this is simply user convenience. It's easier for the user to just set one of those log properties from the project.conf, and the "heavy lifting" such the creation of specific: Logger, LogHandler, LogFormatter, LogAdapters, etc. is done behind the scenes. For that reason I think having this option is useful for our users so they can use the new log feature we implemented.<br>
</blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">It is more convenient for the user if we make them start from scratch, which is why I proposed that we deliver a sample configuration file specifically for this feature.</div>
<div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">My main concern with adding another option is that I don't know how many deployers will really want to log in more than one language at a time. Those deployers who do want it may want more control over where those logs are written than the simple option proposed will give them, too. The logging.conf file gives them complete control for advanced configurations, and a sample file gives them an easy way to turn on simple file logging in multiple languages.</div>
<div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Doug</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
About the idea of providing a sample logging.conf, I think most projects already do that, they ship a sample logging conf. I can add the TranslationLogHandler sample there too.<br>
<br>
[1] <a href="http://docs.openstack.org/grizzly/openstack-compute/admin/content//configuring-logging.html" target="_blank">http://docs.openstack.org/<u></u>grizzly/openstack-compute/<u></u>admin/content//configuring-<u></u>logging.html</a><br>
<br>
Thank you,<br>
<br>
-- <br>
Luis A. García<br>
Cloud Solutions & OpenStack Development<br>
IBM Systems and Technology Group<br>
Ph: <a href="tel:%28915%29%20307-6568" value="+19153076568" target="_blank">(915) 307-6568</a> | T/L: 363-6276<br>
<br>
"Everything should be made as simple as possible, but not simpler."<br>
- Albert Einstein<br>
<br>
"Simple can be harder than complex: You have to work hard to get<br>
your thinking clean to make it simple."<br>
– Steve Jobs<br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</blockquote></div><br></div></div>