<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: arial,helvetica,sans-serif; font-size: 10pt; color: #000000'><br><br><hr id="zwchr"><blockquote id="DWT8180" style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Masayuki Igawa" <masayuki.igawa@gmail.com><br><b>To: </b>"OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org><br><b>Sent: </b>Tuesday, December 24, 2013 11:39:46 AM<br><b>Subject: </b>Re: [openstack-dev] [Tempest][qa] Adding tags to commit messages<br><br>Hi,<br><br>On Tue, Dec 24, 2013 at 6:20 PM, Yair Fried <yfried@redhat.com> wrote:<br>><br>><br>> <hr id="zwchr"><br>>> From: "Masayuki Igawa" <masayuki.igawa@gmail.com><br>>> To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org><br>>> Sent: Tuesday, December 24, 2013 10:42:39 AM<br>>> Subject: Re: [openstack-dev] [Tempest][qa] Adding tags to commit messages<br>>><br>>> Hi,<br>>><br>>> On Tue, Dec 24, 2013 at 3:47 PM, Yair Fried <yfried@redhat.com><br>>> wrote:<br>>> > Hi,<br>>> > Suggestion: Please consider tagging your Tempest commit messages<br>>> > the same way you do your mails in the mailing list<br>>> ><br>>> > Explanation: Since tempest is a single project testing multiple<br>>> > Openstack project we have a very diverse collection of patches as<br>>> > well as reviewers. Tagging our commit messages will allow us to<br>>> > classify patches and thus:<br>>> > 1. Allow reviewer to focus on patches related to their area of<br>>> > expertise<br>>> > 2. Track "trends" in patches - I think we all know that we lack in<br>>> > Neutron testing for example, but can we assess how many network<br>>> > related patches are for awaiting review<br>>> > 3. Future automation of flagging "interesting" patches<br>>> ><br>>> > You can usually tell all of this from reviewing the patch, but by<br>>> > then - you've spent time on a patch you might not even be<br>>> > qualified to review.<br>>> > I suggest we tag our patches with, to start with, the components we<br>>> > are looking to test, and the type of test (sceanrio, api, ...) and<br>>> > that reviewers should -1 untagged patches.<br>>> ><br>>> > I think the tagging should be the 2nd line in the message:<br>>> ><br>>> > ======================================<br>>> > Example commit message<br>>> ><br>>> > [Neutron][Nova][Network][Scenario]<br>>> ><br>>> > Explanation of how this scenario tests both Neutron and Nova<br>>> > Network performance<br>>> ><br>>> > Chang-id XXXXXXXXXXXXXXXXXXX<br>>> > =======================================<br>>> ><br>>> > I would like this to start immediately but what do you guys think?<br>>><br>>> +1<br>>><br>>> And, how about do we the tagging about the services in the<br>>> subject(1st line)?<br>>> For example:<br>>> Neutron:Example commit subject<br>>><br>>> Because the dashboard of the gerrit shows the subject only now.<br>>> I think reviewers can find "interesting" patches easily if the<br>>> dashboard shows the tags.<br>><br>> I just found out you could query search for messages like this:<br>> status:open message:[Neutron]<br><br>Oh, really. Thanks!<br>But the query of 'status:open message:[Neutron]' only doesn't work for me.<br>=======================<br>Application Error<br>Server Error<br>Invalid query: status:open message:[Neutron] line 1:20 no viable<br>alternative at character '['<br>=======================<br>Is there any way working with the brackets?<br></blockquote>Not that I know of - could be a regex sollution?<br>for now search without brackets, maybe?<br><blockquote id="DWT8181" style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;">Sorry for silly question..<br><br>><br>>> This is not so strong opinion because some scenario tests may have<br>>> several services tags.<br>><br>> And you have a limited subject length that's already not enough (for me at least)<br><br>I agree.<br></blockquote>Let's change the subject length limitation to ignore tags<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"># Maybe, it's too long for the subject if already not enough :)<br><br>>><br>>> --<br>>> Masayuki Igawa<br>>><br>>> _______________________________________________<br>>> OpenStack-dev mailing list<br>>> OpenStack-dev@lists.openstack.org<br>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br>>><br>><br>> _______________________________________________<br>> OpenStack-dev mailing list<br>> OpenStack-dev@lists.openstack.org<br>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br><br><br><br>-- <br>Masayuki Igawa<br><br>_______________________________________________<br>OpenStack-dev mailing list<br>OpenStack-dev@lists.openstack.org<br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote><br></div></body></html>