<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body style='font-family: Verdana,Geneva,sans-serif'>
<p>I added it to the page John linked earlier: https://wiki.openstack.org/wiki/ReviewChecklist</p>
<p>-Ben</p>
<p>On 2013-12-23 17:08, Shawn Hartsock wrote:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<p dir="ltr">Where in the wiki is this written down? Maybe I should read some of these entries. I have looked but I can't find it.</p>
<div class="gmail_quote">On Dec 23, 2013 11:56 AM, "Ben Nemec" <<a href="mailto:openstack@nemebean.com">openstack@nemebean.com</a>> wrote:<br />
<blockquote class="gmail_quote" style="margin: 0 0 0 .8ex; border-left: 1px #ccc solid; padding-left: 1ex;">On 2013-12-21 07:24, Matt Riedemann wrote:<br />
<blockquote class="gmail_quote" style="margin: 0 0 0 .8ex; border-left: 1px #ccc solid; padding-left: 1ex;">On 12/19/2013 8:51 AM, John Garbutt wrote:<br />
<blockquote class="gmail_quote" style="margin: 0 0 0 .8ex; border-left: 1px #ccc solid; padding-left: 1ex;">On 4 December 2013 17:10, Russell Bryant <<a href="mailto:rbryant@redhat.com">rbryant@redhat.com</a>> wrote:<br />
<blockquote class="gmail_quote" style="margin: 0 0 0 .8ex; border-left: 1px #ccc solid; padding-left: 1ex;">I think option 3 makes the most sense here (pending anyone saying we<br /> should run away screaming from mox3 for some reason). It's actually<br /> what I had been assuming since this thread a while back.<br /><br /> This means that we don't need to *require* that tests get converted if<br /> you're changing one. It just gets you bonus imaginary internet points.<br /><br /> Requiring mock for new tests seems fine. We can grant exceptions in<br /> specific cases if necessary. In general, we should be using mock for<br /> new tests.</blockquote>
<br /> I have lost track a bit here.<br /><br /> The above seems like a sane approach. Do we all agree on that now?<br /><br /> Can we add the above text into here:<br /><a href="https://wiki.openstack.org/wiki/ReviewChecklist#Nova_Review_Checklist">https://wiki.openstack.org/<span style="text-decoration: underline;"></span>wiki/ReviewChecklist#Nova_<span style="text-decoration: underline;"></span>Review_Checklist</a><br /><br /> John<br /><br /> ______________________________<span style="text-decoration: underline;"></span>_________________<br /> OpenStack-dev mailing list<br /><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.<span style="text-decoration: underline;"></span>org</a><br /><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/<span style="text-decoration: underline;"></span>cgi-bin/mailman/listinfo/<span style="text-decoration: underline;"></span>openstack-dev</a><br /><br /></blockquote>
<br /> Yeah, at some point I wanted to cleanup the various testing guides but<br /> until then I like the idea of just putting something simple into the<br /> nova review checklist. Basically use mock for new tests, mox can be<br /> used in exceptional cases. What I've considered exceptional so far<br /> includes changes that will be backported to a stable release where<br /> mock isn't being used and cases where you basically have to bend over<br /> backwards to work new mock tests into an existing test class that has<br /> lots of existing setUp with mox. However, even in the latter case you<br /> can usually use mock after resetting the mox setup via<br /> self.mox.ResetAll() in the new test case(s).</blockquote>
<br /> I went ahead and added this to the wiki, so it's now an absolutely inviolate policy. Unless, ya know, someone edits the wiki after me. ;-)<br /><br /> Also, I put it in the common section because this doesn't seem like something we should be doing differently per-project. If anyone objects, feel free to add to the discussion here as to why.<br /><br /> Thanks.<br /><br /> -Ben<br /><br /> ______________________________<span style="text-decoration: underline;"></span>_________________<br /> OpenStack-dev mailing list<br /><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.<span style="text-decoration: underline;"></span>org</a><br /><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/<span style="text-decoration: underline;"></span>cgi-bin/mailman/listinfo/<span style="text-decoration: underline;"></span>openstack-dev</a></blockquote>
</div>
</blockquote>
<p> </p>
<div> </div>
</body></html>