<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<div>
<div>+2</div>
<div><br>
</div>
<div>Yes, thanks for raising that concern. I did approve a few patches before we had other core reviewers configured, and I think I also may have also approved a .gitignore patch after. I will strictly conform to our two +2 workflow going forward, as I agree
that merge policy is a good one.</div>
<div><br>
</div>
<div style="font-size:75%">--</div>
<div style="font-size:75%">Adrian</div>
<br>
<br>
-------- Original message --------<br>
From: Russell Bryant <br>
Date:11/18/2013 6:01 AM (GMT-08:00) <br>
To: OpenStack Development Mailing List <br>
Subject: [openstack-dev] [Solum] code review, 2 +2s? <br>
<br>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Most projects follow a review rule that a patch needs 2 +2s before being<br>
approved. I suggest we do the same for Solum. I bring it up since I've<br>
noticed some inconsistency with this so far.<br>
<br>
Thanks,<br>
<br>
-- <br>
Russell Bryant<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
OpenStack-dev@lists.openstack.org<br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div>
</span></font>
</body>
</html>