<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Wed, Nov 13, 2013 at 9:47 AM, John Griffith <span dir="ltr"><<a href="mailto:john.griffith@solidfire.com" target="_blank">john.griffith@solidfire.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">On Wed, Nov 13, 2013 at 7:21 AM, Andrew Laski<br>
<<a href="mailto:andrew.laski@rackspace.com">andrew.laski@rackspace.com</a>> wrote:<br>
> On 11/13/13 at 05:48am, Gary Kotton wrote:<br>
>><br>
>> I recall a few cycles ago having str(uuid.uuid4()) replaced by<br>
>> generate_uuid(). There was actually a helper function in neutron (back when<br>
>> it was called quantum) and it was replaced. So now we are going back…<br>
>> I am not in favor of this change.<br>
><br>
><br>
> I'm also not really in favor of it. Though it is a trivial method having it<br>
> in oslo implies that this is what uuids should look like across OpenStack<br>
> projects.</div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">
And I'm in favor of consistency for uuids across the projects<br>
> because the same parsers and checkers can then be used for input validation<br>
> or log parsing.<br></div></div></blockquote><div><br></div><div>Parsers? UUID's should be treated as opaque strings once they're generated.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5">
><br>
>><br>
>> From: Zhongyue Luo <<a href="mailto:zhongyue.nah@intel.com">zhongyue.nah@intel.com</a><mailto:<a href="mailto:zhongyue.nah@intel.com">zhongyue.nah@intel.com</a>>><br>
>> Reply-To: "OpenStack Development Mailing List (not for usage questions)"<br>
>> <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a><mailto:<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>>><br>
>><br>
>> Date: Wednesday, November 13, 2013 8:07 AM<br>
>> To: OpenStack Development Mailing List<br>
>> <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a><mailto:<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>>><br>
>><br>
>> Subject: [openstack-dev] [ALL] Removing generate_uuid() from uuidutils<br>
>><br>
>> Hi all,<br>
>><br>
>> We had a discussion of the modules that are incubated in Oslo.<br>
>><br>
>><br>
>> <a href="https://etherpad.openstack.org/p/icehouse-oslo-status" target="_blank">https://etherpad.openstack.org/p/icehouse-oslo-status</a><<a href="https://urldefense.proofpoint.com/v1/url?u=https://etherpad.openstack.org/p/icehouse-oslo-status&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=3ns0o3FRyS2%2Fg%2FTFIH7waZX1o%2FHdXvrJ%2FnH9XMCRy08%3D%0A&s=63eaa20d8c94217d86793a24379b4391179fbfa1fb2c961fb37a5512dbdff69a" target="_blank">https://urldefense.proofpoint.com/v1/url?u=https://etherpad.openstack.org/p/icehouse-oslo-status&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=3ns0o3FRyS2%2Fg%2FTFIH7waZX1o%2FHdXvrJ%2FnH9XMCRy08%3D%0A&s=63eaa20d8c94217d86793a24379b4391179fbfa1fb2c961fb37a5512dbdff69a</a>><br>
>><br>
>><br>
>> One of the conclusions we came to was to deprecate/remove uuidutils in<br>
>> this cycle.<br>
>><br>
>> The first step into this change should be to remove generate_uuid() from<br>
>> uuidutils.<br>
>><br>
>> The reason is that 1) generating the UUID string seems trivial enough to<br>
>> not need a function and 2) string representation of uuid4 is not what we<br>
>> want in all projects.<br></div></div></blockquote><div><br></div><div><div>There's room for long term improvement such as decreasing string length, increasing entropy, linearly distributed output, etc. I agree that the current implementation is useless/trivial, but the work to build upon it should happen in oslo to benefit all projects.</div>
<div><div></div></div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">
>><br>
>> To address this, a patch is now on gerrit.<br>
>> <a href="https://review.openstack.org/#/c/56152/" target="_blank">https://review.openstack.org/#/c/56152/</a><<a href="https://urldefense.proofpoint.com/v1/url?u=https://review.openstack.org/%23/c/56152/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=3ns0o3FRyS2%2Fg%2FTFIH7waZX1o%2FHdXvrJ%2FnH9XMCRy08%3D%0A&s=adb860d11d1ad02718e306b9408c603daa00970685a208db375a9ec011f13978" target="_blank">https://urldefense.proofpoint.com/v1/url?u=https://review.openstack.org/%23/c/56152/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=eH0pxTUZo8NPZyF6hgoMQu%2BfDtysg45MkPhCZFxPEq8%3D%0A&m=3ns0o3FRyS2%2Fg%2FTFIH7waZX1o%2FHdXvrJ%2FnH9XMCRy08%3D%0A&s=adb860d11d1ad02718e306b9408c603daa00970685a208db375a9ec011f13978</a>><br>
>><br>
>><br>
>> Each project should directly use the standard uuid module or implement its<br>
>> own helper function to generate uuids if this patch gets in.<br>
>><br>
>> Any thoughts on this change? Thanks.<br>
>><br>
>> --<br>
>> Intel SSG/STO/DCST/CIT<br>
>> 880 Zixing Road, Zizhu Science Park, Minhang District, 200241, Shanghai,<br>
>> China<br>
>> <a href="tel:%2B862161166500" value="+862161166500">+862161166500</a><br>
><br>
><br>
>> _______________________________________________<br>
>> OpenStack-dev mailing list<br>
>> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
</div></div>Trivial or not, people use it and frankly I don't see any value at all<br>
in removing it. As far as the "some projects want a different format<br>
of UUID" that doesn't make a lot of sense to me but if that's what<br>
somebody wants they should write their own method. I strongly agree<br>
with others with respect to the comments around code-churn. I see<br>
little value in this.<br>
<div class=""><div class="h5"><br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><br></div>-Dolph
</div></div>