<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Nov 10, 2013 at 3:50 PM, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Not that I know of. I've considered writing my own gerrit front end<br>
mail service to do just that, because I agree, the current mail volume<br>
and granularity is not very good. If I manage to carve time on it,<br>
I'll do it on stackforge. Joe Gordon took a different approach and<br>
wrote a front end client to mark review threads read that are past.<br></blockquote><div><br></div><div><a href="https://github.com/jogo/gerrit-gmail">https://github.com/jogo/gerrit-gmail</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
On Thu, Nov 7, 2013 at 8:40 PM, David Ripton <<a href="mailto:dripton@redhat.com">dripton@redhat.com</a>> wrote:<br>
> On 11/07/2013 07:54 PM, Sean Dague wrote:<br>
>><br>
>> On 11/08/2013 01:37 AM, Pedro Roque Marques wrote:<br>
>>><br>
>>> Radomir,<br>
>>> An extra issue that i don't believe you've covered so far is about<br>
>>> comment ownership. I've just read an email on the list that follows a<br>
>>> pattern that i've heard many complaints about:<br>
>>> -1 with a reasonable comment, submitter addresses the comment,<br>
>>> reviewer never comes back.<br>
>>><br>
>>> Reviewers do need to allocate time to come back and follow up on the<br>
>>> answers to their comments.<br>
>>><br>
>>> Perhaps there is an issue with the incentive system. You can earn karma<br>
>>> by doing a code review... certainly you want to incentivise developers that<br>
>>> help the project by improving the code quality. But if the incentive system<br>
>>> allows for "drive by shooting" code reviews that can be a problem.<br>
>><br>
>><br>
>> It's not really an incentive system problem, this is some place where<br>
>> there are some gerrit limitations (especially when your list of reviewed<br>
>> code is long). Hopefully once we get a gerrit upgrade we can dashboard<br>
>> out some new items like that via the new rest API.<br>
>><br>
>> I agree that reviewers could be doing better. But definitely also<br>
>> realize that part of this is just that there is *so* much code to review.<br>
>><br>
>> Realize that most core reviewers aren't ignoring or failing to come back<br>
>> on patches intentionally. There is just *so* much of it. I feel guilty<br>
>> all the time by how big a review queue I have, but I also need a few<br>
>> hours a day not doing OpenStack (incredible to believe). This is where<br>
>> non core reviewers can really help in addressing the first couple of<br>
>> rounds of review to prune and improve the easy stuff.<br>
>><br>
>> We're all in this together,<br>
><br>
><br>
> Is there a way for Gerrit to only send email when action is required, rather<br>
> than on any change to any review you've touched? If Gerrit sent less mail,<br>
> it would be easier to treat its mails as a critical call to action to<br>
> re-review. (There's probably a way to use fancy message filtering to<br>
> accomplish this, but that would only work for people willing/able to set up<br>
> such filtering.)<br>
><br>
> --<br>
> David Ripton Red Hat <a href="mailto:dripton@redhat.com">dripton@redhat.com</a><br>
><br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
<br>
</div></div><div class="im">--<br>
Sean Dague<br>
<a href="http://dague.net" target="_blank">http://dague.net</a><br>
<br>
</div><div class=""><div class="h5">_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>